Now that we are using @expo/react-native-action-sheet we need to introduce the following flow types to use the action sheet in our codebase. I read through the source code, and used types.ts when writing the flow types.
Linear Task: ENG-2145
Differential D5523
[native] introduced flow type for @expo/react-native-action-sheet ginsu on Nov 2 2022, 1:05 PM. Authored by Tags None Referenced Files
Details Now that we are using @expo/react-native-action-sheet we need to introduce the following flow types to use the action sheet in our codebase. I read through the source code, and used types.ts when writing the flow types. Linear Task: ENG-2145 All the testing for this diff came from its use in D5524. In that diff I was able to implement the action sheet using the flow types I created in this diff, and I received no flow errors which I believe to be a good indicator that everything is correct. I noticed in the flow docs, there was a section to write tests; however, I also noticed that the other flow-typed library definitions in our code base also don't have any tests, but if this is something we want to get done, I will take a look into it
Diff Detail
Event Timeline
Comment Actions Can we preface property names with + to mark them as ReadOnly and use $ReadOnlyArray instead of Array if possible.
Comment Actions Looks close, it looks like we're missing a property in ActionSheetOptions (correct me if I'm wrong) and we can make the StyleObj comment a little more informative. Preemptively adding @ashoat as blocking reviewer because he has a lot more experience with flow.
|