Context: ENG-1715
Users sign up means that terms of use and privacy policy was accepted, that's why entry in policy_acknowledgments should be added
Paths
| Differential D5664 Authored by kamil on Nov 17 2022, 3:22 AM.
Details Summary Context: ENG-1715 Users sign up means that terms of use and privacy policy was accepted, that's why entry in policy_acknowledgments should be added Test Plan
Diff Detail
Event Timelinekamil held this revision as a draft. Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptNov 17 2022, 3:22 AM2022-11-17 03:22:11 (UTC-8) kamil added a parent revision: D5312: [keyserver] update acknowledgment table in login was performed from proper source. Harbormaster completed remote builds in B13514: Diff 18523.Nov 17 2022, 3:33 AM2022-11-17 03:33:18 (UTC-8) Comment Actions Not a big deal, but I would've probably combined this diff with where userAcknowledgmentUpdater was implemented Comment Actions Looks good, trusting that you followed the Test Plan in your local environment and ensured that rows were created as expected. This revision is now accepted and ready to land.Nov 17 2022, 11:27 AM2022-11-17 11:27:27 (UTC-8) Harbormaster completed remote builds in B13666: Diff 18722.Nov 22 2022, 5:20 AM2022-11-22 05:20:00 (UTC-8) Harbormaster completed remote builds in B13672: Diff 18728.Nov 22 2022, 6:27 AM2022-11-22 06:27:43 (UTC-8) Closed by commit rCOMMc78c1fe5131d: [keyserver] add entry in acknowledgment table on user sign up (authored by kamil). · Explain WhyNov 22 2022, 6:33 AM2022-11-22 06:33:45 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 18523 keyserver/src/creators/account-creator.js
|