Page MenuHomePhabricator
Differential D5664

[keyserver] add entry in acknowledgment table on user sign up
ClosedPublic
Actions

Authored by kamil on Nov 17 2022, 3:22 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 15, 8:30 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:29 PM
Unknown Object (File)
Sun, Dec 15, 8:20 PM
Unknown Object (File)
Sun, Dec 1, 5:04 AM
View All Files
Subscribers
• abosh
ashoat
atul

Details

Reviewers
marcin
tomek
atul
Commits
rCOMMc78c1fe5131d: [keyserver] add entry in acknowledgment table on user sign up
Summary

Context: ENG-1715

Users sign up means that terms of use and privacy policy was accepted, that's why entry in policy_acknowledgments should be added

Test Plan
  1. register in mobile app
  2. check if entry to table was added

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Nov 17 2022, 3:22 AM
kamil held this revision as a draft.
Herald added subscribers: • abosh, atul, ashoat. · View Herald TranscriptNov 17 2022, 3:22 AM
kamil published this revision for review.Nov 17 2022, 3:22 AM
kamil added a reviewer: atul.
kamil added a parent revision: D5312: [keyserver] update acknowledgment table in login was performed from proper source.
kamil added a child revision: D5310: [keyserver] add script to force users to acknowledge updated policy.Nov 17 2022, 3:26 AM
Harbormaster completed remote builds in B13514: Diff 18523.Nov 17 2022, 3:33 AM
ashoat added a comment.Nov 17 2022, 9:38 AM

Not a big deal, but I would've probably combined this diff with where userAcknowledgmentUpdater was implemented

atul accepted this revision.Nov 17 2022, 11:27 AM

Looks good, trusting that you followed the Test Plan in your local environment and ensured that rows were created as expected.

This revision is now accepted and ready to land.Nov 17 2022, 11:27 AM
kamil updated this revision to Diff 18722.Nov 22 2022, 5:06 AM

update function name, rebase

Harbormaster completed remote builds in B13666: Diff 18722.Nov 22 2022, 5:20 AM
tomek accepted this revision.Nov 22 2022, 5:26 AM
tomek added inline comments.
keyserver/src/creators/account-creator.js
114 ↗(On Diff #18722)

Can we combine awaiting this with some other promises?

kamil updated this revision to Diff 18728.Nov 22 2022, 6:13 AM

combine promise

kamil updated this revision to Diff 18729.Nov 22 2022, 6:15 AM

fix - remove old call

Harbormaster completed remote builds in B13672: Diff 18728.Nov 22 2022, 6:27 AM
Harbormaster completed remote builds in B13673: Diff 18729.
Closed by commit rCOMMc78c1fe5131d: [keyserver] add entry in acknowledgment table on user sign up (authored by kamil). · Explain WhyNov 22 2022, 6:33 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMc78c1fe5131d: [keyserver] add entry in acknowledgment table on user sign up.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
22 lines

Diff 18736

View Options

keyserver/src/creators/account-creator.js

Loading...