Paths

Table of Contentst

Differential D5682

[services][blob] Provide S3 and DB to service, add more constants
ClosedPublic
Actions

Authored by bartek on Nov 18 2022, 10:35 AM.

Tags

None

Referenced Files

	F3504802: D5682.diff
	Fri, Dec 20, 10:31 AM

	Unknown Object (File)
	Sun, Dec 15, 5:50 PM

	Unknown Object (File)
	Sun, Dec 15, 5:50 PM

	Unknown Object (File)
	Sun, Dec 15, 5:50 PM

	Unknown Object (File)
	Sun, Dec 15, 5:49 PM

	Unknown Object (File)
	Sun, Dec 15, 5:29 PM

	Unknown Object (File)
	Fri, Dec 6, 9:48 PM

	Unknown Object (File)
	Tue, Nov 26, 5:36 AM

Subscribers

Details

Reviewers

varun
• jon
tomek
marcin

Commits

rCOMMe828574b23a4: [services][blob] Provide S3 and DB to service, add more constants

Summary

Provided the S3 and DynamoDB clients to the MyBlobService implementation, the very similiar way as it is done in Identity Service
Added some constants and grouped them. Their values are taken from various places across the C++ implementation.

Depends on D5681

Test Plan

The service is able to build and start as expected.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 18 2022, 10:35 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptNov 18 2022, 10:35 AM

bartek published this revision for review.Nov 18 2022, 10:45 AM

Harbormaster completed remote builds in B13573: Diff 18592.Nov 18 2022, 10:46 AM

ashoat added 1 blocking reviewer(s): varun.Nov 18 2022, 12:59 PM

bartek added a child revision: D5693: [services][blob] Add methods to manage the blob table.Nov 20 2022, 11:46 PM

varun accepted this revision.Nov 22 2022, 10:01 AM

varun added inline comments.

services/blob/src/service.rs
15 ↗	(On Diff #18592)	I understand you're trying to keep things 1 to 1 with the existing blob service right now, but I think eventually we should expose our own interface on top of `aws_sdk_s3::Client`, similar to what we do for the `DatabaseClient`

This revision is now accepted and ready to land.Nov 22 2022, 10:01 AM

tomek accepted this revision.Nov 23 2022, 2:11 AM

bartek added inline comments.Nov 24 2022, 12:47 AM

services/blob/src/service.rs
15 ↗	(On Diff #18592)	Yeah, definitely - It would look even cleaner that way. I'll create a task to keep track of this. Edit: https://linear.app/comm/issue/ENG-2341/blob-service-create-s3-client-abstraction

Rebase

Harbormaster completed remote builds in B13724: Diff 18804.Nov 24 2022, 1:02 AM

bartek added a child revision: D5716: [services][blob] Use chrono::DateTime for timestamps.Nov 24 2022, 1:27 AM

bartek removed a child revision: D5693: [services][blob] Add methods to manage the blob table.Nov 24 2022, 1:28 AM

Closed by commit rCOMMe828574b23a4: [services][blob] Provide S3 and DB to service, add more constants (authored by bartek). · Explain WhyNov 29 2022, 5:15 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMe828574b23a4: [services][blob] Provide S3 and DB to service, add more constants.

bartek mentioned this in D5785: [services][blob] Introduce S3 Client abstraction.Dec 1 2022, 5:01 AM

bartek mentioned this in D5786: [services][blob] Implement S3Client methods.

bartek mentioned this in D5787: [services][blob] Use S3 abstraction in service.Dec 1 2022, 5:07 AM

bartek mentioned this in rCOMM3015fb6fc902: [services][blob] Introduce S3 Client abstraction.Dec 7 2022, 10:37 AM

bartek mentioned this in rCOMM12f6b3c72fb3: [services][blob] Implement S3Client methods.

bartek mentioned this in rCOMM812f339aefe6: [services][blob] Use S3 abstraction in service.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

22 lines

16 lines

19 lines

Diff 18804

services/blob/src/constants.rs

Loading...

services/blob/src/main.rs

Loading...

services/blob/src/service.rs

Loading...