Paths

Table of Contentst

[native] Pass TextMessage.onPress down via context
ClosedPublic
Actions

Authored by ashoat on Nov 29 2022, 8:10 PM.

Details

Reviewers

rohan
atul
ginsu
michal

Commits

rCOMMb589a7bbd40b: [native] Pass TextMessage.onPress down via context

Summary

Descendants of this component will need to call onPress.

Test Plan

I tested this in combination with the next diff. See attached video in the next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 29 2022, 8:10 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 29 2022, 8:10 PM

ashoat added a child revision: D5764: [native] Render second TextMessage with all Texts pressable when markdownHasPressable.Nov 29 2022, 8:12 PM

ashoat edited the test plan for this revision. (Show Details)

ashoat added a parent revision: D5755: [native] Add markdownASTHasPressable to TextMessageMarkdownContext.

Harbormaster completed remote builds in B13861: Diff 18985.Nov 29 2022, 8:24 PM

ashoat requested review of this revision.Nov 29 2022, 8:24 PM

atul accepted this revision.Nov 30 2022, 9:21 AM

This revision is now accepted and ready to land.Nov 30 2022, 9:21 AM

rohan accepted this revision.Nov 30 2022, 9:29 AM

Closed by commit rCOMMb589a7bbd40b: [native] Pass TextMessage.onPress down via context (authored by ashoat). · Explain WhyNov 30 2022, 11:10 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb589a7bbd40b: [native] Pass TextMessage.onPress down via context.

Revision Contents
Changeset List

Path

Size

native/

chat/

message-press-responder-context.js

13 lines

text-message-tooltip-button.react.js

24 lines

text-message.react.js

38 lines

Diff 19024

View Options

native/chat/message-press-responder-context.js

View Options

native/chat/text-message-tooltip-button.react.js

View Options

native/chat/text-message.react.js

[native] Pass TextMessage.onPress down via contextClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 19024

native/chat/message-press-responder-context.js

native/chat/text-message-tooltip-button.react.js

native/chat/text-message.react.js

[native] Pass TextMessage.onPress down via context
ClosedPublic
Actions

Revision Contents
Changeset List