[services][blob] Add custom errors to db methods
ClosedPublic
Actions

Authored by bartek on Dec 13 2022, 8:25 AM.

Details

Reviewers

varun
tomek
• jon
michal

Commits

rCOMMda907a55261b: [services][blob] Add custom errors to db methods

Summary

Continuation of adopting custom errors. This diff replaces most of anyhow errors with dedicated structures.

Depends on D5857

Test Plan

Artifically caused a few errors on purpose to see how they are handled.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Dec 13 2022, 8:25 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 13 2022, 8:25 AM

bartek added a child revision: D5859: [services][blob] Use new errors in service. Move logs.Dec 13 2022, 8:28 AM

Harbormaster completed remote builds in B14105: Diff 19305.Dec 13 2022, 8:34 AM

Typo fix

Harbormaster completed remote builds in B14107: Diff 19307.Dec 13 2022, 8:50 AM

Rebase onto curretn master

bartek published this revision for review.Jan 23 2023, 3:25 PM

bartek added a reviewer: michal.

Harbormaster completed remote builds in B15534: Diff 21189.Jan 23 2023, 3:29 PM

• jon accepted this revision.Jan 23 2023, 6:11 PM

varun accepted this revision.Jan 24 2023, 9:09 PM

This revision is now accepted and ready to land.Jan 24 2023, 9:09 PM

Closed by commit rCOMMda907a55261b: [services][blob] Add custom errors to db methods. · Explain WhyJan 25 2023, 10:53 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMda907a55261b: [services][blob] Add custom errors to db methods.

Revision Contents
Changeset List

Path

Size

services/

blob/

src/

database.rs

82 lines

s3.rs

5 lines

Diff 21189

View Options

services/blob/src/database.rs