Page MenuHomePhabricator
Differential D6062

[native] Remove background from modal items
ClosedPublic
Actions

Authored by inka on Dec 28 2022, 12:07 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 3:47 PM
Unknown Object (File)
Sat, Nov 23, 2:23 PM
Unknown Object (File)
Sat, Nov 23, 11:48 AM
Unknown Object (File)
Wed, Nov 6, 3:36 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
• przemek
tomek
michal
Commits
rCOMMca9417df6504: [native] Remove background from modal items
Summary

Related issue: https://linear.app/comm/issue/ENG-2437/address-feedback-from-design-team-on-light-mode (see discussion in comments)
The background of items in sidebars modal and subchannels modal was beging set to the same value as the modals background in the dark mode, and a different value in the light mode, which resulted in a very weird effect. By removing the
backgroundColor option I'm setting it to be transparent, so now elements have the same background colour as the modal, which is what we want.

This is what used to happen:

image.png (1×512 px, 51 KB)

This is what happens now:

image.png (744×672 px, 67 KB)

Test Plan

Run ios (iPhone 13) and android (Android 12) simulators, checked in dark and light mode that in sidebar and subchannels modals items backgrounds look right.

Diff Detail

Repository
rCOMM Comm
Branch
inka/community_drawer
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka created this revision.Dec 28 2022, 12:07 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptDec 28 2022, 12:07 AM
inka edited the summary of this revision. (Show Details)Dec 28 2022, 12:12 AM
Harbormaster completed remote builds in B14816: Diff 20207.Dec 28 2022, 12:19 AM
inka requested review of this revision.Dec 28 2022, 12:19 AM
inka added a child revision: D6073: [native] style SidebarListModal, SubchannelsModal, ThreadListModal.Dec 28 2022, 8:48 AM
inka added a parent revision: D5972: [native] Add subchannnels modal.
tomek accepted this revision.Dec 29 2022, 3:35 AM

Does it still look correctly in dark mode?

This revision is now accepted and ready to land.Dec 29 2022, 3:35 AM
inka added a comment.EditedDec 29 2022, 4:14 AM
In D6062#182583, @tomek wrote:

Does it still look correctly in dark mode?

Yes, screenshots in the issue

inka updated this revision to Diff 20320.Dec 29 2022, 4:14 AM

Rebase

Harbormaster completed remote builds in B14903: Diff 20320.Dec 29 2022, 4:25 AM
Closed by commit rCOMMca9417df6504: [native] Remove background from modal items (authored by • InkaSokolowska). · Explain WhyDec 29 2022, 9:26 AM
This revision was automatically updated to reflect the committed changes.
• InkaSokolowska added a commit: rCOMMca9417df6504: [native] Remove background from modal items.

Revision Contents
Changeset List

Diff 20207

View Options

native/chat/sidebar-list-modal.react.js

Loading...
View Options

native/chat/subchannels-list-modal.react.js

Loading...