Page MenuHomePhabricator

[native] Remove background from modal items
ClosedPublic

Authored by inka on Dec 28 2022, 12:07 AM.
Tags
None
Referenced Files
F3354115: D6062.diff
Sat, Nov 23, 11:48 AM
Unknown Object (File)
Wed, Nov 6, 3:36 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Nov 4, 11:20 PM
Unknown Object (File)
Mon, Oct 28, 7:04 AM
Unknown Object (File)
Mon, Oct 28, 7:04 AM
Subscribers

Details

Summary

Related issue: https://linear.app/comm/issue/ENG-2437/address-feedback-from-design-team-on-light-mode (see discussion in comments)
The background of items in sidebars modal and subchannels modal was beging set to the same value as the modals background in the dark mode, and a different value in the light mode, which resulted in a very weird effect. By removing the
backgroundColor option I'm setting it to be transparent, so now elements have the same background colour as the modal, which is what we want.

This is what used to happen:

image.png (1×512 px, 51 KB)

This is what happens now:

image.png (744×672 px, 67 KB)

Test Plan

Run ios (iPhone 13) and android (Android 12) simulators, checked in dark and light mode that in sidebar and subchannels modals items backgrounds look right.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

inka requested review of this revision.Dec 28 2022, 12:19 AM

Does it still look correctly in dark mode?

This revision is now accepted and ready to land.Dec 29 2022, 3:35 AM
In D6062#182583, @tomek wrote:

Does it still look correctly in dark mode?

Yes, screenshots in the issue