Page MenuHomePhabricator
Differential D6224

[lib] Convert generatesNotifs to async function
ClosedPublic
Actions

Authored by ashoat on Jan 10 2023, 3:10 PM.
Tags
None
Referenced Files
F3489158: D6224.diff
Wed, Dec 18, 11:48 AM
Unknown Object (File)
Thu, Nov 28, 4:24 AM
Unknown Object (File)
Fri, Nov 22, 4:10 AM
Unknown Object (File)
Fri, Nov 22, 4:10 AM
Unknown Object (File)
Fri, Nov 22, 4:03 AM
Unknown Object (File)
Nov 9 2024, 1:19 AM
Unknown Object (File)
Nov 5 2024, 4:28 AM
Unknown Object (File)
Nov 4 2024, 4:38 AM
View All 96 Files
Subscribers
atul
tomek

Details

Reviewers
ginsu
Commits
rCOMM597c4ae467a8: [lib] Convert generatesNotifs to async function
Summary

Depends on D6223

Test Plan

Flow, plus tested chat creation, message creation, liking and unliking a user's message, and liking and unliking somebody else's mes
sage

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Jan 10 2023, 3:10 PM
Herald added subscribers: atul, tomek. · View Herald TranscriptJan 10 2023, 3:10 PM
ashoat added a child revision: D6186: [keyserver] reaction messages only notifiy author of target message.Jan 10 2023, 3:11 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 10 2023, 3:17 PM
Harbormaster failed remote builds in B15237: Diff 20768!
Harbormaster completed remote builds in B15237: Diff 20768.Jan 10 2023, 3:46 PM
ashoat requested review of this revision.Jan 10 2023, 3:46 PM
ginsu accepted this revision.Jan 10 2023, 4:08 PM
This revision is now accepted and ready to land.Jan 10 2023, 4:08 PM
Closed by commit rCOMM597c4ae467a8: [lib] Convert generatesNotifs to async function (authored by ashoat). · Explain WhyJan 10 2023, 6:54 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM597c4ae467a8: [lib] Convert generatesNotifs to async function.
tomek mentioned this in D6530: [keyserver] Fix publishing new messages / latest messages when a new message is created..Feb 2 2023, 9:00 AM
tomek mentioned this in rCOMM01e98d908f0c: [keyserver] Fix publishing new messages / latest messages when a new message is….Feb 2 2023, 9:30 AM

Revision Contents
Changeset List

Diff 20775

View Options

keyserver/src/creators/message-creator.js

Loading...
View Options

lib/shared/messages/add-members-message-spec.js

Loading...
View Options

lib/shared/messages/change-role-message-spec.js

Loading...
View Options

lib/shared/messages/change-settings-message-spec.js

Loading...
View Options

lib/shared/messages/create-entry-message-spec.js

Loading...
View Options

lib/shared/messages/create-sidebar-message-spec.js

Loading...
View Options

lib/shared/messages/create-sub-thread-message-spec.js

Loading...
View Options

lib/shared/messages/create-thread-message-spec.js

Loading...
View Options

lib/shared/messages/delete-entry-message-spec.js

Loading...
View Options

lib/shared/messages/edit-entry-message-spec.js

Loading...
View Options

lib/shared/messages/join-thread-message-spec.js

Loading...
View Options

lib/shared/messages/leave-thread-message-spec.js

Loading...
View Options

lib/shared/messages/message-spec.js

Loading...
View Options

lib/shared/messages/multimedia-message-spec.js

Loading...
View Options

lib/shared/messages/reaction-message-spec.js

Loading...
View Options

lib/shared/messages/remove-members-message-spec.js

Loading...
View Options

lib/shared/messages/restore-entry-message-spec.js

Loading...
View Options

lib/shared/messages/sidebar-source-message-spec.js

Loading...
View Options

lib/shared/messages/text-message-spec.js

Loading...
View Options

lib/shared/messages/unsupported-message-spec.js

Loading...
View Options

lib/shared/messages/update-relationship-message-spec.js

Loading...