Page MenuHomePhabricator
Differential D6621

[CMake] Resolve rust library include directory
ClosedPublic
Actions

Authored by • jon on Feb 5 2023, 6:26 PM.
Tags
None
Referenced Files
F3347278: D6621.diff
Fri, Nov 22, 11:38 AM
Unknown Object (File)
Wed, Nov 20, 3:16 PM
Unknown Object (File)
Tue, Nov 19, 12:50 AM
Unknown Object (File)
Tue, Nov 19, 12:50 AM
Unknown Object (File)
Fri, Nov 15, 1:53 AM
Unknown Object (File)
Fri, Nov 15, 1:52 AM
Unknown Object (File)
Sat, Nov 9, 11:17 AM
Unknown Object (File)
Fri, Nov 1, 8:19 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
varun
• max
bartek
Commits
rCOMMcf721bda9450: [CMake] Resolve rust library include directory
Summary

When consuming rust_native_library from many
projects, the directory path needs to be resolved fully to work
when the build directory may be different; as is the case when
using 'add_subdirectory()' in CMake.

REALPATH was chosen over ABSPATH as REALPATH will still provide
an abssolute path but with symlinks resolved.

Depends on D6498

Test Plan

Android build gate is successful
Tested fully in D6507

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

• jon created this revision.Feb 5 2023, 6:26 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 5 2023, 6:26 PM
• jon added a child revision: D6507: [Android] Use native modules from CMake.Feb 5 2023, 6:26 PM
Harbormaster completed remote builds in B16159: Diff 22109.Feb 5 2023, 6:41 PM
• jon requested review of this revision.Feb 5 2023, 6:41 PM
• max accepted this revision.Feb 6 2023, 3:15 AM
• max added inline comments.
shared/cmake/corrosion-cxx.cmake
56 ↗(On Diff #22109)

Maybe we should change the variable name to reflect that this is a real path.

This revision is now accepted and ready to land.Feb 6 2023, 3:15 AM
• jon updated this revision to Diff 22220.Feb 7 2023, 10:27 AM
• jon marked an inline comment as done.

Apply feedback, rebase on master

• jon marked an inline comment as done.Feb 7 2023, 10:27 AM
• jon added inline comments.
shared/cmake/corrosion-cxx.cmake
56 ↗(On Diff #22109)

split the difference with REALPATH_BINARY_DIR. As BINARY_REALPATH says "realpath to a binary file" to me.

Harbormaster completed remote builds in B16248: Diff 22220.Feb 7 2023, 10:42 AM
• jon added a child revision: D6721: [Android] Refactor openssl code to separate file and target.Feb 13 2023, 11:08 AM
Closed by commit rCOMMcf721bda9450: [CMake] Resolve rust library include directory (authored by • jon). · Explain WhyFeb 20 2023, 6:29 PM
This revision was automatically updated to reflect the committed changes.
• jon marked an inline comment as done.
• jon added a commit: rCOMMcf721bda9450: [CMake] Resolve rust library include directory.

Revision Contents
Changeset List

PathSize
shared/
cmake/
8 lines

Diff 22220

View Options

shared/cmake/corrosion-cxx.cmake

Loading...