[lib] Disable text/media notif when starting sidebar
ClosedPublic
Actions

Authored by ashoat on Feb 20 2023, 5:33 PM.

Details

Reviewers

Commits

rCOMMb0b5ac75c171: [lib] Disable text/media notif when starting sidebar

Summary

More context in ENG-3041. Today we send two notifs when a sidebar is created; this diff makes it so we only send one notif.

Depends on D6797

Test Plan

I tested this whole stack as follows:

Create a sidebar by sending a text message on web
Create a sidebar by sending a media message on web
Create a sidebar by sending a text message on native
Create a sidebar by sending a media message on native

In all of these cases, I confirmed that only one notif was delivered (the notif for the text/media message was skipped)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Feb 20 2023, 5:33 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 20 2023, 5:33 PM

ashoat added a child revision: D6799: [keyserver][lib] Add sidebarCreation to keyserver message creation endpoints.Feb 20 2023, 5:34 PM

Harbormaster completed remote builds in B16656: Diff 22784.Feb 20 2023, 5:49 PM

ashoat requested review of this revision.Feb 20 2023, 5:49 PM

atul accepted this revision.Feb 21 2023, 12:09 AM

This revision is now accepted and ready to land.Feb 21 2023, 12:09 AM

Closed by commit rCOMMb0b5ac75c171: [lib] Disable text/media notif when starting sidebar (authored by ashoat). · Explain WhyFeb 21 2023, 6:19 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMb0b5ac75c171: [lib] Disable text/media notif when starting sidebar.

Revision Contents
Changeset List

Path

Size

lib/

shared/

messages/

multimedia-message-spec.js

5 lines

text-message-spec.js

5 lines

Diff 22835

View Options

lib/shared/messages/multimedia-message-spec.js