Page MenuHomePhabricator

[lib] Allow multiple messages in CreateSidebar notificationTexts
ClosedPublic

Authored by ashoat on Feb 23 2023, 1:12 PM.
Tags
None
Referenced Files
F3513199: D6868.diff
Sat, Dec 21, 11:09 PM
Unknown Object (File)
Nov 18 2024, 5:59 PM
Unknown Object (File)
Oct 27 2024, 1:54 PM
Unknown Object (File)
Oct 24 2024, 3:55 PM
Unknown Object (File)
Oct 24 2024, 5:24 AM
Unknown Object (File)
Oct 24 2024, 4:45 AM
Unknown Object (File)
Oct 24 2024, 4:42 AM
Unknown Object (File)
Oct 18 2024, 5:43 PM
Subscribers

Details

Summary

In a future diff we introduce a notificationCollapseKey so that we have access to the SIDEBAR_SOURCE when generating the notif text for the CREATE_SIDEBAR mention.

Ahead of that, this diff updates the notificationTexts code so that it doesn't assert that there is only one message in the collapse result.

Depends on D6867

Test Plan

In combination with the rest of the stack, I confirmed that a sidebar started in response to a text message that @-mentions somebody will result in the @-mentioned user receiving a custom notif that ends with "that tagged you"

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage