Page MenuHomePhabricator
Differential D6949

[native] Fetch and parse feature flags response
ClosedPublic
Actions

Authored by tomek on Mar 3 2023, 4:29 AM.
Tags
None
Referenced Files
F5893736: D6949.diff
Thu, Apr 17, 9:36 AM
Unknown Object (File)
Fri, Apr 4, 11:29 AM
Unknown Object (File)
Thu, Apr 3, 1:32 PM
Unknown Object (File)
Wed, Apr 2, 4:02 PM
Unknown Object (File)
Wed, Apr 2, 4:02 PM
Unknown Object (File)
Wed, Apr 2, 4:02 PM
Unknown Object (File)
Wed, Mar 19, 3:57 AM
Unknown Object (File)
Mar 12 2025, 1:14 AM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
kamil
bartek
inka
Commits
rCOMMa910cf9ae1af: [native] Fetch and parse feature flags response
Summary

Fetch a config, parse, and use in a state.

Depends on D6948

Test Plan

Added a console log to check if the state is set correctly after successful call to feature flags service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Mar 3 2023, 4:29 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 3 2023, 4:29 AM
Harbormaster completed remote builds in B17092: Diff 23400.Mar 3 2023, 4:44 AM
tomek requested review of this revision.Mar 3 2023, 4:44 AM
tomek edited the test plan for this revision. (Show Details)Mar 3 2023, 5:52 AM
bartek added inline comments.Mar 3 2023, 6:22 AM
lib/utils/feature-flags-utils.js
22–31 ↗(On Diff #23400)

Why not response.json()?

native/components/feature-flags-provider.react.js
53 ↗(On Diff #23400)

This adds more context

tomek added inline comments.Mar 3 2023, 6:55 AM
lib/utils/feature-flags-utils.js
22–31 ↗(On Diff #23400)

I used the same approach that we use in callServerEndpoint but agree, using .json() might be better.

native/components/feature-flags-provider.react.js
53 ↗(On Diff #23400)

Good idea!

tomek updated this revision to Diff 23403.Mar 3 2023, 7:04 AM

Improve parsing and error handling

Harbormaster completed remote builds in B17093: Diff 23403.Mar 3 2023, 7:19 AM
bartek accepted this revision.Mar 3 2023, 7:50 AM
This revision is now accepted and ready to land.Mar 3 2023, 7:50 AM
Closed by commit rCOMMa910cf9ae1af: [native] Fetch and parse feature flags response (authored by tomek). · Explain WhyMar 3 2023, 9:02 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMa910cf9ae1af: [native] Fetch and parse feature flags response.
tomek mentioned this in D6967: [native] Fix useIsCurrentUserStaff hook.Mar 7 2023, 2:07 AM
tomek mentioned this in rCOMM3dc46d29f50b: [native] Fix useIsCurrentUserStaff hook.Mar 7 2023, 7:12 AM

Revision Contents
Changeset List

PathSize
lib/
facts/
7 lines
utils/
28 lines
native/
components/
33 lines

Diff 23408

View Options

lib/facts/feature-flags.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
View Options

lib/utils/feature-flags-utils.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
View Options

native/components/feature-flags-provider.react.js

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall