Page MenuHomePhabricator

[native] Fetch and parse feature flags response
ClosedPublic

Authored by tomek on Mar 3 2023, 4:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 24, 11:17 AM
Unknown Object (File)
Sat, May 11, 10:25 AM
Unknown Object (File)
Sat, May 11, 10:25 AM
Unknown Object (File)
Sat, May 11, 10:24 AM
Unknown Object (File)
Sat, May 11, 10:24 AM
Unknown Object (File)
Sat, May 11, 10:24 AM
Unknown Object (File)
Mon, May 6, 12:18 AM
Unknown Object (File)
Sun, May 5, 1:54 AM
Subscribers

Details

Summary

Fetch a config, parse, and use in a state.

Depends on D6948

Test Plan

Added a console log to check if the state is set correctly after successful call to feature flags service.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek requested review of this revision.Mar 3 2023, 4:44 AM
lib/utils/feature-flags-utils.js
22–31 ↗(On Diff #23400)
native/components/feature-flags-provider.react.js
53 ↗(On Diff #23400)

This adds more context

lib/utils/feature-flags-utils.js
22–31 ↗(On Diff #23400)

I used the same approach that we use in callServerEndpoint but agree, using .json() might be better.

native/components/feature-flags-provider.react.js
53 ↗(On Diff #23400)

Good idea!

Improve parsing and error handling

This revision is now accepted and ready to land.Mar 3 2023, 7:50 AM