Paths

Table of Contentst

Differential D6949

[native] Fetch and parse feature flags response
ClosedPublic
Actions

Authored by tomek on Mar 3 2023, 4:29 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Nov 4, 5:18 PM

	Unknown Object (File)
	Wed, Oct 30, 4:57 AM

	Unknown Object (File)
	Wed, Oct 30, 4:57 AM

	Unknown Object (File)
	Wed, Oct 30, 4:57 AM

	Unknown Object (File)
	Wed, Oct 30, 4:56 AM

	Unknown Object (File)
	Wed, Oct 30, 4:54 AM

	Unknown Object (File)
	Oct 21 2024, 5:59 PM

	Unknown Object (File)
	Oct 21 2024, 12:37 PM

Subscribers

Details

Reviewers

kamil
bartek
inka

Commits

rCOMMa910cf9ae1af: [native] Fetch and parse feature flags response

Summary

Fetch a config, parse, and use in a state.

Depends on D6948

Test Plan

Added a console log to check if the state is set correctly after successful call to feature flags service.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Mar 3 2023, 4:29 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptMar 3 2023, 4:29 AM

Harbormaster completed remote builds in B17092: Diff 23400.Mar 3 2023, 4:44 AM

tomek requested review of this revision.Mar 3 2023, 4:44 AM

tomek edited the test plan for this revision. (Show Details)Mar 3 2023, 5:52 AM

bartek added inline comments.Mar 3 2023, 6:22 AM

lib/utils/feature-flags-utils.js
22–31 ↗	(On Diff #23400)	Why not response.json()?
native/components/feature-flags-provider.react.js
53 ↗	(On Diff #23400)	This adds more context

tomek added inline comments.Mar 3 2023, 6:55 AM

lib/utils/feature-flags-utils.js
22–31 ↗	(On Diff #23400)	I used the same approach that we use in `callServerEndpoint` but agree, using `.json()` might be better.
native/components/feature-flags-provider.react.js
53 ↗	(On Diff #23400)	Good idea!

Improve parsing and error handling

Harbormaster completed remote builds in B17093: Diff 23403.Mar 3 2023, 7:19 AM

bartek accepted this revision.Mar 3 2023, 7:50 AM

This revision is now accepted and ready to land.Mar 3 2023, 7:50 AM

Closed by commit rCOMMa910cf9ae1af: [native] Fetch and parse feature flags response (authored by tomek). · Explain WhyMar 3 2023, 9:02 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMa910cf9ae1af: [native] Fetch and parse feature flags response.

tomek mentioned this in D6967: [native] Fix useIsCurrentUserStaff hook.Mar 7 2023, 2:07 AM

tomek mentioned this in rCOMM3dc46d29f50b: [native] Fix useIsCurrentUserStaff hook.Mar 7 2023, 7:12 AM

Revision Contents
Changeset List

Path

Size

lib/

facts/

feature-flags.js

7 lines

utils/

feature-flags-utils.js

28 lines

native/

components/

feature-flags-provider.react.js

33 lines

Diff 23408

lib/facts/feature-flags.js

Loading...

lib/utils/feature-flags-utils.js

Loading...

native/components/feature-flags-provider.react.js

Loading...