[services][feature-flags] Add configuration for http server
ClosedPublic
Actions

Authored by tomek on Feb 23 2023, 8:33 AM.

Details

Reviewers

michal
bartek
• jon
varun

Commits

rCOMM584ead41422b: [services][feature-flags] Add configuration for http server

Summary

The only thing we configure at this point is the port. Later we're going to also configure https and related keys.

Depends on D6858

Test Plan

Tested with the rest of the stack.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 23 2023, 8:33 AM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 23 2023, 8:33 AM

tomek edited the summary of this revision. (Show Details)Feb 23 2023, 8:33 AM

tomek added a parent revision: D6858: [services][feature-flags] Determine enabled features set.

tomek added a child revision: D6860: [services][feature-flags] Add hello world http server.Feb 23 2023, 8:38 AM

Harbormaster completed remote builds in B16834: Diff 23013.Feb 23 2023, 8:49 AM

tomek requested review of this revision.Feb 23 2023, 8:49 AM

bartek accepted this revision.Feb 24 2023, 2:18 AM

This revision is now accepted and ready to land.Feb 24 2023, 2:18 AM

Closed by commit rCOMM584ead41422b: [services][feature-flags] Add configuration for http server (authored by tomek). · Explain WhyFeb 28 2023, 6:26 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMM584ead41422b: [services][feature-flags] Add configuration for http server.

Revision Contents
Changeset List

Path

Size

services/

feature-flags/

src/

config.rs

6 lines

constants.rs

1 line

Diff 23233

View Options

services/feature-flags/src/config.rs