Page MenuHomePhabricator
Differential D6860

[services][feature-flags] Add hello world http server
ClosedPublic
Actions

Authored by tomek on Feb 23 2023, 8:38 AM.
Tags
None
Referenced Files
F5903462: D6860.id.diff
Thu, Apr 17, 1:19 PM
Unknown Object (File)
Fri, Apr 11, 3:57 PM
Unknown Object (File)
Tue, Apr 8, 1:07 PM
Unknown Object (File)
Sat, Apr 5, 12:29 PM
Unknown Object (File)
Fri, Apr 4, 4:52 PM
Unknown Object (File)
Thu, Apr 3, 1:28 PM
Unknown Object (File)
Thu, Apr 3, 1:28 PM
Unknown Object (File)
Thu, Apr 3, 1:28 PM
View All Files
Subscribers
ashoat
atul

Details

Reviewers
michal
bartek
• jon
varun
Commits
rCOMMd00c6f858ba2: [services][feature-flags] Add hello world http server
Summary

Just a hello world http server. There are a couple of interesting servers available in Rust, but I've chosen this because it is relatively high level, performant, and easily integrates with https.

Depends on D6859

Test Plan

Send GET to / and check if response is returned. Checked if both 127.0.0.1 and [::1] work.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek created this revision.Feb 23 2023, 8:38 AM
Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 23 2023, 8:38 AM
tomek added a child revision: D6861: [services][feature-flags] Introduce `features` endpoint.Feb 23 2023, 8:43 AM
Harbormaster completed remote builds in B16835: Diff 23014.Feb 23 2023, 8:54 AM
tomek requested review of this revision.Feb 23 2023, 8:54 AM
bartek accepted this revision.Feb 24 2023, 4:22 AM
bartek added inline comments.
services/feature-flags/src/service.rs
19 ↗(On Diff #23014)

Should we listen on IPv4 only?

https://docs.rs/actix-web/latest/actix_web/struct.HttpServer.html#method.bind

This revision is now accepted and ready to land.Feb 24 2023, 4:22 AM
tomek added inline comments.Feb 27 2023, 4:45 AM
services/feature-flags/src/service.rs
19 ↗(On Diff #23014)

Good question! According to the docs you mentioned

When addr includes a hostname, it is possible for this method to bind to both the IPv4 and IPv6 addresses that result from a DNS lookup.

So using localhost will bind to both addresses.
On the other hand

Note that, if a DNS lookup is required, resolving hostnames is a blocking operation.

Which should be quick for localhost, but maybe it is better to use v4 and v6 addresses explicitly.

tomek updated this revision to Diff 23152.Feb 27 2023, 4:56 AM

Bind IPv6 address

tomek edited the test plan for this revision. (Show Details)Feb 27 2023, 4:56 AM
Harbormaster failed remote builds in B16940: Diff 23152!Feb 27 2023, 5:00 AM
tomek updated this revision to Diff 23170.Feb 27 2023, 8:28 AM

Rebase

Harbormaster completed remote builds in B16949: Diff 23170.Feb 27 2023, 8:43 AM
Closed by commit rCOMMd00c6f858ba2: [services][feature-flags] Add hello world http server (authored by tomek). · Explain WhyFeb 28 2023, 6:26 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMd00c6f858ba2: [services][feature-flags] Add hello world http server.

Revision Contents
Changeset List

PathSize
services/
feature-flags/
1 line
src/
11 lines
13 lines

Diff 23234

View Options

services/feature-flags/Cargo.lock

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
View Options

services/feature-flags/Cargo.toml

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
View Options

services/feature-flags/src/main.rs

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall
View Options

services/feature-flags/src/service.rs

FROM node:16.13-bullseye FROM node:16.13-bullseye
WORKDIR /app WORKDIR /app
#-------------------------------------------------------------------------------
# STEP 0: INSTALL PREREQS
# Install prereqs first so we don't have to reinstall them if anything changes
#-------------------------------------------------------------------------------
# We need python2 for a build script that the sqlite3 npm package uses # We need python2 for a build script that the sqlite3 npm package uses
# We use rsync in the prod-build yarn script
RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \ RUN apt-get update && DEBIAN_FRONTEND=noninteractive apt-get install -y \
python2 \ python2 \
rsync \
&& rm -rf /var/lib/apt/lists/* && rm -rf /var/lib/apt/lists/*
RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2 RUN update-alternatives --install /usr/bin/python python /usr/bin/python2 2
#-------------------------------------------------------------------------------
# STEP 1: YARN CLEANINSTALL
# We run yarn cleaninstall before copying most of the files in for build caching
#-------------------------------------------------------------------------------
# Copy in package.json and yarn.lock files # Copy in package.json and yarn.lock files
COPY package.json yarn.lock . COPY package.json yarn.lock .
COPY keyserver/package.json keyserver/.flowconfig keyserver/ COPY keyserver/package.json keyserver/.flowconfig keyserver/
COPY lib/package.json lib/.flowconfig lib/ COPY lib/package.json lib/.flowconfig lib/
COPY web/package.json web/.flowconfig web/ COPY web/package.json web/.flowconfig web/
COPY native/package.json native/.flowconfig native/ COPY native/package.json native/.flowconfig native/
COPY landing/package.json landing/.flowconfig landing/ COPY landing/package.json landing/.flowconfig landing/
# Copy in files needed for patch-package and pod-patch # Copy in files needed for patch-package and pod-patch
COPY patches patches/ COPY patches patches/
COPY native/ios/pod-patch native/ios/pod-patch/ COPY native/ios/pod-patch native/ios/pod-patch/
COPY native/ios/Podfile native/ios/ COPY native/ios/Podfile native/ios/
# We run yarn cleaninstall before copying most of the files in for build caching # Actually run yarn
RUN yarn cleaninstall RUN yarn cleaninstall