[services][feature-flags] Add hello world http server
ClosedPublic
Actions

Authored by tomek on Feb 23 2023, 4:38 PM.

Details

Reviewers

michal
bartek
• jon
varun

Commits

rCOMMd00c6f858ba2: [services][feature-flags] Add hello world http server

Summary

Just a hello world http server. There are a couple of interesting servers available in Rust, but I've chosen this because it is relatively high level, performant, and easily integrates with https.

Depends on D6859

Test Plan

Send GET to / and check if response is returned. Checked if both 127.0.0.1 and [::1] work.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Feb 23 2023, 4:38 PM

Herald added subscribers: atul, ashoat. · View Herald TranscriptFeb 23 2023, 4:38 PM

tomek added a child revision: D6861: [services][feature-flags] Introduce `features` endpoint.Feb 23 2023, 4:43 PM

Harbormaster completed remote builds in B16835: Diff 23014.Feb 23 2023, 4:54 PM

tomek requested review of this revision.Feb 23 2023, 4:54 PM

bartek accepted this revision.Feb 24 2023, 12:22 PM

bartek added inline comments.

services/feature-flags/src/service.rs
19 ↗	(On Diff #23014)	Should we listen on IPv4 only? https://docs.rs/actix-web/latest/actix_web/struct.HttpServer.html#method.bind

This revision is now accepted and ready to land.Feb 24 2023, 12:22 PM

tomek added inline comments.Feb 27 2023, 12:45 PM

services/feature-flags/src/service.rs
19 ↗	(On Diff #23014)	Good question! According to the docs you mentioned When addr includes a hostname, it is possible for this method to bind to both the IPv4 and IPv6 addresses that result from a DNS lookup. So using `localhost` will bind to both addresses. On the other hand Note that, if a DNS lookup is required, resolving hostnames is a blocking operation. Which should be quick for localhost, but maybe it is better to use v4 and v6 addresses explicitly.