The final diff about accessing the database.
Depends on D6856
Details
Details
Create some dummy data in the db. Query the db, log the result and verify that the parsed data is correct.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/feature-flags/src/database.rs | ||
|---|---|---|
| 209–210 ↗ | (On Diff #23011) | Maybe we should extract these strings as constants? pub const PLATFORM_IOS: &str = "IOS"; Or even do an enum implementation impl fmt::Display for Platform { fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result { fmt::Debug::fmt(self, f) } } // then let platform_value = platform.to_string() But this might be an overkill, it trades simplicity for flexibility/extensibility |
| services/feature-flags/src/database.rs | ||
|---|---|---|
| 209–210 ↗ | (On Diff #23011) | Agree that extracting as constants makes sense. And also, I don't think that introducing more complicated approach is a good idea - it's just too complicated for such a simple thing. |