Page MenuHomePhabricator
Differential D7209

[web] render thread avatars in the community drawer
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 4:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 10:56 AM
Unknown Object (File)
Sat, Dec 7, 8:22 PM
Unknown Object (File)
Sat, Dec 7, 8:21 PM
Unknown Object (File)
Sat, Dec 7, 8:21 PM
Unknown Object (File)
Wed, Dec 4, 3:23 AM
Unknown Object (File)
Wed, Dec 4, 3:23 AM
Unknown Object (File)
Nov 17 2024, 1:45 AM
Unknown Object (File)
Nov 17 2024, 12:47 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMMe50a4ac71429: [web] render thread avatars in the community drawer
Summary

render thread avatars in the community drawer

This diff won't be landed until avatars is given the green light to be released

Depends on D7208

Test Plan

Please view the screenshots to see the changes I made:

Before:

Screenshot 2023-03-27 at 7.15.24 PM.png (2×3 px, 870 KB)

After:

Screenshot 2023-03-27 at 7.15.51 PM.png (1×3 px, 692 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 27 2023, 4:18 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 4:18 PM
ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:19 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu added a parent revision: D7208: [web] render user avatars in typeahead tooltip.
ginsu attached a referenced file: F448642: Screenshot 2023-03-27 at 7.15.51 PM.png. (Show Details)
ginsu attached a referenced file: F448641: Screenshot 2023-03-27 at 7.15.24 PM.png. (Show Details)
ginsu added a child revision: D7210: [web] render thread avatars on chat screen.Mar 27 2023, 4:24 PM
Harbormaster completed remote builds in B17716: Diff 24249.Mar 27 2023, 4:33 PM
ginsu requested review of this revision.Mar 27 2023, 4:33 PM
atul accepted this revision.Mar 28 2023, 1:22 PM
This revision is now accepted and ready to land.Mar 28 2023, 1:22 PM
ginsu updated this revision to Diff 24545.Apr 3 2023, 1:48 AM
ginsu edited the test plan for this revision. (Show Details)

replace Avatar with ThreadAvatar

Harbormaster completed remote builds in B17915: Diff 24545.Apr 3 2023, 2:03 AM
ginsu updated this revision to Diff 24611.Apr 4 2023, 11:07 AM

rebase before landing

Harbormaster completed remote builds in B17974: Diff 24611.Apr 4 2023, 11:32 AM
Closed by commit rCOMMe50a4ac71429: [web] render thread avatars in the community drawer (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe50a4ac71429: [web] render thread avatars in the community drawer.

Revision Contents
Changeset List

Diff 24611

View Options

web/sidebar/community-drawer-item.css

Loading...
View Options

web/sidebar/community-drawer-item.react.js

Loading...