Page MenuHomePhabricator
Differential D7210

[web] render thread avatars on chat screen
ClosedPublic
Actions

Authored by ginsu on Mar 27 2023, 4:22 PM.
Tags
None
Referenced Files
F3521568: D7210.diff
Mon, Dec 23, 3:57 AM
Unknown Object (File)
Sat, Dec 7, 8:22 PM
Unknown Object (File)
Sat, Dec 7, 8:22 PM
Unknown Object (File)
Sat, Dec 7, 8:22 PM
Unknown Object (File)
Nov 8 2024, 9:54 AM
Unknown Object (File)
Nov 8 2024, 9:54 AM
Unknown Object (File)
Nov 8 2024, 9:54 AM
Unknown Object (File)
Nov 5 2024, 2:21 AM
View All Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
atul
ashoat
Commits
rCOMM1a8084846369: [web] render thread avatars on chat screen
Summary

Render thread avatars on chat screen. This includes the chat thread list item, the thread top bar, and and the nav state info bar

This diff won't be landed until avatars is given the green light to be released

Depends on D7209

Test Plan

Please view the screenshots below to see the changes I made:

Before:

Screenshot 2023-03-27 at 7.21.37 PM.png (2×3 px, 1 MB)

After:

Screenshot 2023-03-27 at 7.21.50 PM.png (2×3 px, 1 MB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Mar 27 2023, 4:22 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMar 27 2023, 4:22 PM
ginsu edited the summary of this revision. (Show Details)Mar 27 2023, 4:24 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, ashoat.
ginsu added a parent revision: D7209: [web] render thread avatars in the community drawer.
ginsu attached a referenced file: F448671: Screenshot 2023-03-27 at 7.21.50 PM.png. (Show Details)
ginsu attached a referenced file: F448670: Screenshot 2023-03-27 at 7.21.37 PM.png. (Show Details)
Harbormaster completed remote builds in B17717: Diff 24250.Mar 27 2023, 4:37 PM
ginsu requested review of this revision.Mar 27 2023, 4:37 PM
atul accepted this revision.Mar 28 2023, 1:34 PM
This revision is now accepted and ready to land.Mar 28 2023, 1:34 PM
ginsu updated this revision to Diff 24546.Apr 3 2023, 1:49 AM

replace Avatar with ThreadAvatar

ginsu added a child revision: D7275: [web] render thread avatars in thread subchannel/sidebar modals.Apr 3 2023, 2:00 AM
Harbormaster completed remote builds in B17916: Diff 24546.Apr 3 2023, 2:04 AM
ginsu updated this revision to Diff 24612.Apr 4 2023, 11:08 AM

rebase before landing

Harbormaster completed remote builds in B17975: Diff 24612.Apr 4 2023, 11:36 AM
Closed by commit rCOMM1a8084846369: [web] render thread avatars on chat screen (authored by ginsu). · Explain WhyApr 4 2023, 11:53 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1a8084846369: [web] render thread avatars on chat screen.

Revision Contents
Changeset List

Diff 24250

View Options

web/chat/chat-thread-list-item.react.js

Loading...
View Options

web/chat/chat-thread-list.css

Loading...
View Options

web/chat/thread-top-bar.css

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...
View Options

web/navigation-panels/nav-state-info-bar.css

Loading...
View Options

web/navigation-panels/nav-state-info-bar.react.js

Loading...