[web] introduce ThreadAvatar component
ClosedPublic
Actions

Authored by ginsu on Apr 2 2023, 11:13 PM.

Details

Reviewers

ashoat
atul

Commits

rCOMM41c71a9612a4: [web] introduce ThreadAvatar component

Summary

After some discussion with @ashoat and @atul about how to fetch the ens avatars we decided to have two separate components to render avatars: UserAvatar and ThreadAvatar. This diff handles ThreadAvatar.

This diff is pretty much a copy of D7262

Depends on D7273

Test Plan

I was able to render all three avatar types: Emoji, Image, and ENS:

Emoji:

Screenshot 2023-04-03 at 2.25.49 AM.png (2×3 px, 939 KB)

Image (by hardcoding const avatarInfo = { type: 'image', uri: 'https://picsum.photos/200' }):

Screenshot 2023-04-03 at 2.34.26 AM.png (2×3 px, 951 KB)

ENS (by hardcoding const avatarInfo = { type: 'ens' } and the same ensAvatarURI I tested in D7262):

Screenshot 2023-04-03 at 2.26.01 AM.png (2×3 px, 942 KB)

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ginsu created this revision.Apr 2 2023, 11:13 PM

Herald added a subscriber: tomek. · View Herald TranscriptApr 2 2023, 11:13 PM

Harbormaster completed remote builds in B17906: Diff 24532.Apr 2 2023, 11:29 PM

ginsu requested review of this revision.Apr 2 2023, 11:29 PM

ginsu edited the summary of this revision. (Show Details)Apr 2 2023, 11:36 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7232: [native] Extract LoadableImage component.

ginsu attached a referenced file: F459483: Screenshot 2023-04-03 at 2.26.01 AM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7273: [web] introduce UserAvatar component.

ginsu attached a referenced file: F459482: Screenshot 2023-04-03 at 2.34.26 AM.png. (Show Details)

ginsu attached a referenced file: F459481: Screenshot 2023-04-03 at 2.25.49 AM.png. (Show Details)

ginsu removed a parent revision: D7232: [native] Extract LoadableImage component.Apr 3 2023, 1:23 AM

ginsu added a child revision: D7194: [web] render user avatar in account screen.Apr 3 2023, 1:28 AM

Thanks for testing those scenarios in Test Plan. Question about API inline.

web/components/thread-avatar.react.js
27 ↗	(On Diff #24532)	Are we not going to run into the same issue as with `UserAvatar` of having to make sure we're drilling `threadInfo` everywhere (I don't know, haven't taken a close look)? Should the prop just be `threadID` to match what we're doing for `UserAvatar`s?

This revision is now accepted and ready to land.Apr 3 2023, 10:41 AM

ashoat added inline comments.Apr 3 2023, 4:01 PM

web/components/thread-avatar.react.js
27 ↗	(On Diff #24532)	@ginsu initially did `threadID`, but I requested `threadInfo` after noticing all callsites already had `threadInfo`. So no extra `threadInfo` fetching/drilling was necessary, and some `threadInfo` fetching was saved