Paths

Table of Contentst

Differential D7324

[native] introduce EmojiAvatarCreation into profile and chat navigators
ClosedPublic
Actions

Authored by ginsu on Apr 5 2023, 12:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 7, 6:00 AM

	Unknown Object (File)
	Mon, Nov 4, 5:09 AM

	Unknown Object (File)
	Mon, Nov 4, 5:09 AM

	Unknown Object (File)
	Mon, Nov 4, 5:09 AM

	Unknown Object (File)
	Mon, Nov 4, 5:09 AM

	Unknown Object (File)
	Mon, Nov 4, 5:09 AM

	Unknown Object (File)
	Sun, Oct 27, 2:20 AM

	Unknown Object (File)
	Sun, Oct 27, 2:20 AM

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM9d60ddb2a63b: [native] introduce EmojiAvatarCreation into profile and chat navigators

Summary

introduce the EmojiAvatarCreation into the profile and chat navigators. I also changed the header options to reflect what we have in the designs

Design:

Screenshot 2023-04-04 at 3.44.01 PM.png (1×556 px, 76 KB)

Depends on D7428

Test Plan

I was able to navigate to this screen locally and the header/back button reflect what I have in the header options for both user and thread avatars:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 5 2023, 12:19 PM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 5 2023, 12:19 PM

fix header title

ginsu edited the summary of this revision. (Show Details)Apr 5 2023, 12:23 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu attached a referenced file: F464539: Screen Recording 2023-04-05 at 3.22.25 PM.mov. (Show Details)

ginsu attached a referenced file: F464538: Screenshot 2023-04-04 at 3.44.01 PM.png. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7323: [native] introduce emoji avatar creation screen.

Harbormaster completed remote builds in B18020: Diff 24687.Apr 5 2023, 12:35 PM

Harbormaster completed remote builds in B18021: Diff 24688.Apr 5 2023, 12:38 PM

ginsu requested review of this revision.Apr 5 2023, 12:38 PM

ashoat accepted this revision.Apr 5 2023, 12:43 PM

ashoat added inline comments.

native/profile/profile.react.js
47 ↗	(On Diff #24688)	This title feels weird. Is it in the designs? Maybe we should use "Emoji avatar selection"?

This revision is now accepted and ready to land.Apr 5 2023, 12:43 PM

ginsu edited the summary of this revision. (Show Details)Apr 7 2023, 12:42 PM

ginsu added a parent revision: D7359: [native] implement onPressSetAvatar function.

ginsu removed a parent revision: D7323: [native] introduce emoji avatar creation screen.

ginsu added inline comments.

native/profile/profile.react.js
47 ↗	(On Diff #24688)	It is in the designs, but I think "Emoji avatar selection" sounds better

ginsu attached a referenced file: F469353: Screenshot 2023-04-04 at 3.44.01 PM.png. (Show Details)Apr 7 2023, 12:44 PM

address ashoat's comments

Harbormaster completed remote builds in B18131: Diff 24833.Apr 7 2023, 1:04 PM

ginsu added a child revision: D7378: [native] add edit avatar badge to thread avatar.Apr 10 2023, 12:48 PM

Need to update the imports for profile and additionally will add EmojiAvatarCreation for thread avatars.

ginsu removed a parent revision: D7359: [native] implement onPressSetAvatar function.Apr 13 2023, 9:18 AM

ginsu edited the summary of this revision. (Show Details)

ginsu mentioned this in D7423: [native] move emoji avatar creation from profile directory to components directory.Apr 13 2023, 9:22 AM

ginsu removed a child revision: D7378: [native] add edit avatar badge to thread avatar.

fix import and add EmojiAvatarCreation to chats

This revision is now accepted and ready to land.Apr 13 2023, 1:07 PM

ginsu retitled this revision from [native] introduce EmojiAvatarCreation into profile navigator to [native] introduce EmojiAvatarCreation into profile and chat navigators.Apr 13 2023, 1:08 PM

ginsu edited the summary of this revision. (Show Details)

ginsu edited the test plan for this revision. (Show Details)

ginsu attached a referenced file: F484215: Screen Recording 2023-04-13 at 1.16.41 PM.mov. (Show Details)

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D7428: [native] extend emoji avatar creation to handle thread avatars.

Harbormaster completed remote builds in B18347: Diff 25139.Apr 13 2023, 1:25 PM

ginsu added a child revision: D7438: [native] introduce EditAvatar component.Apr 13 2023, 3:40 PM

rebase before landing

Harbormaster completed remote builds in B18377: Diff 25175.Apr 14 2023, 11:26 AM

Closed by commit rCOMM9d60ddb2a63b: [native] introduce EmojiAvatarCreation into profile and chat navigators (authored by ginsu). · Explain WhyApr 14 2023, 11:36 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM9d60ddb2a63b: [native] introduce EmojiAvatarCreation into profile and chat navigators.

Revision Contents
Changeset List

Path

Size

native/

chat/

11 lines

profile/

profile.react.js

11 lines

Diff 25182

native/chat/chat.react.js

Loading...

native/profile/profile.react.js

Loading...