Page MenuHomePhabricator

[lib] introduce savedEmojiAvatarSelectorForThread selector
ClosedPublic

Authored by ginsu on Apr 13 2023, 9:52 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 7 2024, 5:01 AM
Unknown Object (File)
Oct 27 2024, 2:19 AM
Unknown Object (File)
Oct 27 2024, 2:19 AM
Unknown Object (File)
Oct 27 2024, 2:19 AM
Unknown Object (File)
Oct 27 2024, 2:19 AM
Unknown Object (File)
Oct 27 2024, 2:14 AM
Unknown Object (File)
Sep 26 2024, 7:00 AM
Unknown Object (File)
Sep 21 2024, 8:47 AM
Subscribers

Details

Summary

Similar logic to D7402 but for thread avatars. In addition to creating the selector, I needed to create a small utility function: getAvatarForThread which factors out most of the logic in useAvatarForThread but now we can easily use this logic in the savedEmojiAvatarSelectorForThread selector

Depends on D7424

Test Plan

All thread avatars still render properly (shows that getAvatarForThread works as expected) , and the reset functionality for thread avatars behaves as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu edited the summary of this revision. (Show Details)
lib/shared/avatar-utils.js
117 ↗(On Diff #25130)

This should fix the crash Ted experienced

This revision is now accepted and ready to land.Apr 14 2023, 6:38 AM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing