[lib] introduce getRandomDefaultEmojiAvatar function
ClosedPublic
Actions

Authored by ginsu on Apr 12 2023, 11:49 AM.

Details

Reviewers

ashoat
atul

Commits

rCOMMc8f9f5955783: [lib] introduce getRandomDefaultEmojiAvatar function

Summary

small utiltity function that will be used in the following diff

Test Plan

Tested in a subsequent diff locally that I was getting a random default avatar on return when calling the function

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 12 2023, 11:49 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 12 2023, 11:49 AM

ginsu added reviewers: ashoat, atul.Apr 12 2023, 11:50 AM

Harbormaster completed remote builds in B18278: Diff 25050.Apr 12 2023, 12:07 PM

ginsu requested review of this revision.Apr 12 2023, 12:07 PM

ginsu added a child revision: D7402: [lib] introduce savedEmojiAvatarSelectorForCurrentUser selector.Apr 12 2023, 12:14 PM

I would have included this in D7402. It's hard to understand the need for this function (vs. the existing hash function approach) without reading your comment here. In general I think small utility functions like this should be introduced alongside their callsite, to make it easier for the reviewer to understand why / how they're being introduced. A good rule of thumb (not a hard rule) is whether you have unit tests for it.

Accepting to unblock though

This revision is now accepted and ready to land.Apr 12 2023, 5:48 PM

rebase before landing

In general I think small utility functions like this should be introduced alongside their callsite, to make it easier for the reviewer to understand why / how they're being introduced. A good rule of thumb (not a hard rule) is whether you have unit tests for it.

Will keep this rule of thumb in mind moving forward

Harbormaster completed remote builds in B18292: Diff 25069.Apr 12 2023, 11:07 PM

Closed by commit rCOMMc8f9f5955783: [lib] introduce getRandomDefaultEmojiAvatar function (authored by ginsu). · Explain WhyApr 12 2023, 11:23 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMc8f9f5955783: [lib] introduce getRandomDefaultEmojiAvatar function.

Revision Contents
Changeset List

Path

Size

lib/

shared/

avatar-utils.js

6 lines

Diff 25072

View Options

lib/shared/avatar-utils.js

Show First 20 Lines • Show All 191 Lines • ▼ Show 20 Lines	if (messagesFromDatabase.size() > 0) {
// if there are undelivered messages in the database. If so, we are		// if there are undelivered messages in the database. If so, we are
// erasing the messages to deliver from rabbitMQ which are handled by		// erasing the messages to deliver from rabbitMQ which are handled by
// DeliveryBroker.		// DeliveryBroker.
DeliveryBroker::getInstance().erase(clientDeviceID);		DeliveryBroker::getInstance().erase(clientDeviceID);
}		}
tunnelbroker::GetResponse response;		tunnelbroker::GetResponse response;
auto respondToWriter =		auto respondToWriter =
[&writer, &response](std::string fromDeviceID, std::string payload) {		[&writer, &response](std::string fromDeviceID, std::string payload) {
response.set_fromdeviceid(fromDeviceID);		response.mutable_responsemessage()->set_fromdeviceid(fromDeviceID);
response.set_payload(payload);		response.mutable_responsemessage()->set_payload(payload);
if (!writer->Write(response)) {		if (!writer->Write(response)) {
throw std::runtime_error(		throw std::runtime_error(
"gRPC: 'Get' writer error on sending data to the client");		"gRPC: 'Get' writer error on sending data to the client");
}		}
response.Clear();		response.Clear();
};		};
for (auto &messageFromDatabase : messagesFromDatabase) {		for (auto &messageFromDatabase : messagesFromDatabase) {
respondToWriter(		respondToWriter(
Show All 28 Lines

[lib] introduce getRandomDefaultEmojiAvatar functionClosedPublicActions