Paths

Table of Contentst

Differential D7424

[native] introduce useSaveUserAvatar hook
ClosedPublic
Actions

Authored by ginsu on Apr 13 2023, 8:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Jun 24, 4:33 PM

	Unknown Object (File)
	Mon, Jun 24, 12:30 AM

	Unknown Object (File)
	Fri, Jun 21, 2:22 PM

	Unknown Object (File)
	Fri, Jun 21, 4:53 AM

	Unknown Object (File)
	Fri, Jun 21, 4:49 AM

	Unknown Object (File)
	Tue, Jun 18, 7:25 AM

	Unknown Object (File)
	Thu, Jun 13, 4:48 PM

	Unknown Object (File)
	Thu, Jun 13, 8:01 AM

View All 56 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM7f75aff169bf: [native] introduce useSaveUserAvatar hook

Summary

To better prepare the EmojiAvatarCreation component to handle both user and thread avatars I want to factor out this User avatar specfic function into a hook in the avatar util file so that the component won't be as cluttered when we extend to thread avatars

Depends on D7423

Test Plan

flow and I am still able to save my avatar with the expected behavior

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 13 2023, 8:41 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 8:41 AM

ginsu edited the summary of this revision. (Show Details)Apr 13 2023, 8:44 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7423: [native] move emoji avatar creation from profile directory to components directory.

fix feature flag gate

Harbormaster completed remote builds in B18331: Diff 25117.Apr 13 2023, 8:59 AM

Harbormaster completed remote builds in B18332: Diff 25118.Apr 13 2023, 9:05 AM

ginsu requested review of this revision.Apr 13 2023, 9:05 AM

remove console.log

ginsu added a child revision: D7426: [lib] introduce savedEmojiAvatarSelectorForThread selector.Apr 13 2023, 9:56 AM

ginsu mentioned this in D7427: [native] introduce useSaveThreadAvatar hook.Apr 13 2023, 10:02 AM

Didn't review too closely since it looks like just a "factor out" diff. Please wait for CI to pass before landing

This revision is now accepted and ready to land.Apr 13 2023, 10:02 AM

Harbormaster completed remote builds in B18338: Diff 25129.Apr 13 2023, 10:09 AM

Closed by commit rCOMM7f75aff169bf: [native] introduce useSaveUserAvatar hook (authored by ginsu). · Explain WhyApr 13 2023, 12:57 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM7f75aff169bf: [native] introduce useSaveUserAvatar hook.

ginsu mentioned this in rCOMMaf21cf8f11cb: [native] introduce useSaveThreadAvatar hook.Apr 14 2023, 11:33 AM

Revision Contents
Changeset List

Path

Size

native/

components/

emoji-avatar-creation.react.js

38 lines

utils/

avatar-utils.js

47 lines

Diff 25137

native/components/emoji-avatar-creation.react.js

Loading...

native/utils/avatar-utils.js

Loading...