Paths

Table of Contentst

Differential D7428

[native] extend emoji avatar creation to handle thread avatars
ClosedPublic
Actions

Authored by ginsu on Apr 13 2023, 10:19 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Nov 9, 12:09 AM

	Unknown Object (File)
	Tue, Nov 5, 4:21 AM

	Unknown Object (File)
	Sun, Oct 27, 2:19 AM

	Unknown Object (File)
	Sun, Oct 27, 2:19 AM

	Unknown Object (File)
	Sun, Oct 27, 2:19 AM

	Unknown Object (File)
	Sun, Oct 27, 2:19 AM

	Unknown Object (File)
	Sun, Oct 27, 2:14 AM

	Unknown Object (File)
	Sep 26 2024, 3:06 PM

View All 80 Files

Subscribers

Details

Reviewers

ashoat
atul

Commits

rCOMM567d450ef219: [native] extend emoji avatar creation to handle thread avatars

Summary

Extend emoji avatar creation to handle thread avatars. I decided that the best way to handle this extension is to use threadID as a route param and if threadID (which is needed to save a thread avatar) is present then we should know that we are working with a thread avatar and not a user avatar

Depends on D7427

Test Plan

Able to change both user avatars and thread avatars with the same expected user experience

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 13 2023, 10:19 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 13 2023, 10:19 AM

ginsu edited the summary of this revision. (Show Details)Apr 13 2023, 10:27 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: ashoat, atul.

ginsu added a parent revision: D7427: [native] introduce useSaveThreadAvatar hook.

ginsu attached a referenced file: F484017: Screen Recording 2023-04-13 at 1.16.41 PM.mov. (Show Details)

Harbormaster completed remote builds in B18341: Diff 25132.Apr 13 2023, 10:36 AM

ginsu requested review of this revision.Apr 13 2023, 10:36 AM

ginsu added a child revision: D7324: [native] introduce EmojiAvatarCreation into profile and chat navigators.Apr 13 2023, 1:09 PM

ashoat accepted this revision.Apr 14 2023, 6:40 AM

This revision is now accepted and ready to land.Apr 14 2023, 6:40 AM

rebase before landing

Harbormaster completed remote builds in B18376: Diff 25174.Apr 14 2023, 11:24 AM

Closed by commit rCOMM567d450ef219: [native] extend emoji avatar creation to handle thread avatars (authored by ginsu). · Explain WhyApr 14 2023, 11:34 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM567d450ef219: [native] extend emoji avatar creation to handle thread avatars.

Revision Contents
Changeset List

Path

Size

native/

components/

emoji-avatar-creation.react.js

66 lines

navigation/

4 lines

Diff 25181

native/components/emoji-avatar-creation.react.js

Loading...

native/navigation/route-names.js

Loading...