Page MenuHomePhabricator
Differential D7403

[native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation
ClosedPublic
Actions

Authored by ginsu on Apr 12 2023, 12:17 PM.
Tags
None
Referenced Files
F2109914: D7403.id25120.diff
Tue, Jun 25, 6:01 PM
F2106807: D7403.id.diff
Tue, Jun 25, 8:51 AM
F2106665: D7403.id25054.diff
Tue, Jun 25, 8:28 AM
Unknown Object (File)
Sat, Jun 22, 5:53 PM
Unknown Object (File)
Sun, Jun 16, 1:55 AM
Unknown Object (File)
Fri, Jun 14, 8:46 AM
Unknown Object (File)
Wed, Jun 12, 6:02 PM
Unknown Object (File)
Sat, Jun 8, 8:27 PM
View All 63 Files
Subscribers
ashoat
atul
tomek

Details

Reviewers
ashoat
atul
Commits
rCOMMcaf80b74e363: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation
Summary

Based on feedback I got in D7359, when we "reset" the emoji avatar during the emoji avatar creation flow , we want to reset to the current state in redux which we are considering the source of truth. This is the diff that implements the selector I introduced in the previous diff

Depends on D7402

Test Plan

The reset functionality behaves as expected:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Apr 12 2023, 12:17 PM
Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptApr 12 2023, 12:17 PM
ginsu edited the summary of this revision. (Show Details)Apr 12 2023, 12:24 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: ashoat, atul.
ginsu added a parent revision: D7402: [lib] introduce savedEmojiAvatarSelectorForCurrentUser selector.
ginsu attached a referenced file: F481856: Screen Recording 2023-04-12 at 3.00.00 PM.mov. (Show Details)
ginsu attached a referenced file: F481857: Screen Recording 2023-04-12 at 2.59.18 PM.mov. (Show Details)
ginsu added a child revision: D7359: [native] implement onPressSetAvatar function.Apr 12 2023, 12:26 PM
Harbormaster completed remote builds in B18281: Diff 25054.Apr 12 2023, 12:34 PM
ginsu requested review of this revision.Apr 12 2023, 12:34 PM
ashoat accepted this revision.Apr 12 2023, 5:55 PM
ashoat mentioned this in D7402: [lib] introduce savedEmojiAvatarSelectorForCurrentUser selector.
ashoat added inline comments.
native/profile/emoji-avatar-creation.react.js
17 ↗(On Diff #25054)

See my note about making this selector return a function in D7402

This revision is now accepted and ready to land.Apr 12 2023, 5:56 PM
ginsu updated this revision to Diff 25071.Apr 12 2023, 10:51 PM

address comments

Harbormaster completed remote builds in B18294: Diff 25071.Apr 12 2023, 11:09 PM
ashoat added inline comments.Apr 13 2023, 5:40 AM
native/profile/emoji-avatar-creation.react.js
22–27 ↗(On Diff #25071)

We could pass initialization functions to useState to avoid needing to call savedEmojiAvatarFunc() when we don't need to, but it's not a huge deal

42 ↗(On Diff #25071)

We could call savedEmojiAvatarFunc() here to avoid calling it unless we need to

ginsu updated this revision to Diff 25113.Apr 13 2023, 8:18 AM

address feedback

Harbormaster completed remote builds in B18329: Diff 25113.Apr 13 2023, 8:37 AM
ashoat added inline comments.Apr 13 2023, 9:00 AM
native/profile/emoji-avatar-creation.react.js
25 ↗(On Diff #25113)

Shouldn't this be .color?

ginsu added inline comments.Apr 13 2023, 9:07 AM
native/profile/emoji-avatar-creation.react.js
25 ↗(On Diff #25113)

thanks for catching that

ginsu updated this revision to Diff 25120.Apr 13 2023, 9:09 AM

fix

Harbormaster completed remote builds in B18333: Diff 25120.Apr 13 2023, 9:28 AM
Closed by commit rCOMMcaf80b74e363: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation (authored by ginsu). · Explain WhyApr 13 2023, 9:30 AM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMcaf80b74e363: [native] use savedEmojiAvatarSelectorForCurrentUser in EmojiAvatarCreation.

Revision Contents
Changeset List

PathSize
native/
navigation/
3 lines
profile/
36 lines

Diff 25124

View Options

native/navigation/route-names.js

Loading...
View Options

native/profile/emoji-avatar-creation.react.js

Loading...