[services][blob] Introduce HTTP context utils
ClosedPublic
Actions

Authored by bartek on Apr 17 2023, 5:57 AM.

Details

Reviewers

marcin
tomek
• jon
michal

Commits

rCOMM9f9e5dac8726: [services][blob] Introduce HTTP context utils

Summary

This diff introduces a AppContext structure that is passed to each HTTP request handler. It contains references
to database and S3 instances along with some utilities that will be used in the handlers.

Depends on D7444

Test Plan

This is not yet used, it will be tested with the next diff.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Apr 17 2023, 5:57 AM

bartek held this revision as a draft.

Herald added subscribers: atul, ashoat. · View Herald TranscriptApr 17 2023, 5:58 AM

bartek added a child revision: D7465: [services][blob] Implement Get blob HTTP handler.Apr 17 2023, 6:05 AM

Harbormaster completed remote builds in B18407: Diff 25215.Apr 17 2023, 6:16 AM

bartek published this revision for review.Apr 18 2023, 12:06 AM

• jon accepted this revision.Apr 18 2023, 8:06 AM

• jon added inline comments.

services/blob/src/http/context.rs
43–50	if `Result<Option<_>>` is going to be a theme moving forward, might be nice to create a utility function. let result = self.db.find_reverse_index_by_holder(holder).await; handle_db_query(\|index\| self.find_s3_path_by_reverse_index(&index).await) For two "similar usages", I think it would be a pre-mature refactor right now, but a 3rd instance would probably make it worthwhile to clean it up