Page MenuHomePhabricator
Differential D7500

[native] Style RegistrationNavigator header
ClosedPublic
Actions

Authored by ashoat on Apr 18 2023, 12:54 PM.
Tags
None
Referenced Files
F2172102: D7500.diff
Tue, Jul 2, 6:53 PM
Unknown Object (File)
Mon, Jul 1, 4:18 AM
Unknown Object (File)
Wed, Jun 26, 9:06 PM
Unknown Object (File)
Wed, Jun 26, 8:25 PM
Unknown Object (File)
Mon, Jun 24, 9:24 AM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:03 PM
Unknown Object (File)
Sun, Jun 23, 4:02 PM
View All 54 Files
Subscribers
tomek

Details

Reviewers
ginsu
atul
Commits
rCOMM61d1812e0178: [native] Style RegistrationNavigator header
Summary

The header should be transparent and should only have a single back button.

Depends on D7496

Test Plan
beforeafter

Diff Detail

Repository
rCOMM Comm
Branch
ashoat/wizard
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat created this revision.Apr 18 2023, 12:54 PM
Herald added a subscriber: tomek. · View Herald TranscriptApr 18 2023, 12:54 PM
ashoat edited the test plan for this revision. (Show Details)Apr 18 2023, 12:55 PM
ashoat edited the test plan for this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)
ashoat edited the test plan for this revision. (Show Details)
ashoat added inline comments.Apr 18 2023, 12:59 PM
native/account/registration/keyserver-selection.react.js
19

Context on why this is necessary is here.

I tried putting this in RegistrationNavigator but didn't succeed, either by nesting it between the Registration.Navigator and Registration.Screen, nor by putting it above the Registration.Navigator.

I think we'll need this for every screen, so I'll factor it out into a more convenient component in the next diff.

ashoat added a child revision: D7501: [native] Introduce RegistrationContainer.Apr 18 2023, 1:05 PM
Harbormaster completed remote builds in B18475: Diff 25301.Apr 18 2023, 1:12 PM
ashoat requested review of this revision.Apr 18 2023, 1:12 PM
atul accepted this revision.Apr 19 2023, 9:44 AM
This revision is now accepted and ready to land.Apr 19 2023, 9:44 AM
Closed by commit rCOMM61d1812e0178: [native] Style RegistrationNavigator header (authored by ashoat). · Explain WhyApr 19 2023, 6:39 PM
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM61d1812e0178: [native] Style RegistrationNavigator header.

Revision Contents
Changeset List

PathSize
native/
account/
registration/
13 lines
10 lines

Diff 25301

View Options

native/account/registration/keyserver-selection.react.js

Loading...
View Options

native/account/registration/registration-navigator.react.js

Loading...