[web] Don't hide pinned messages on reload
ClosedPublic
Actions

Authored by inka on May 25 2023, 10:17 AM.

Details

Reviewers

• kuba
michal
ginsu
rohan

Commits

rCOMM23f6660f18d8: [web] Don't hide pinned messages on reload

Summary

issue: https://linear.app/comm/issue/ENG-3896/message-pin-view-on-web-refreshes-when-user-navigates-back-and-away
When the user navigates to a different tab / app the connectionStatus is changed to disconnected. This indirectly causes the callFetchPinnedMessages variable in MessageResultsModal to change when the user comes back to comm, which
in turn calls the Effect hook that fetches pinned messages.
Previously in such case we stopped showing the old results, and show only the loading indicator. Now we show the old results and the loading indicator above them, and once the fetch is completed the results are updated.
Some changes to css were made to stop the modal from resizing when the loading indicator appears / disappears (resulting in jumping screen effect).

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

inka created this revision.May 25 2023, 10:17 AM

Herald added subscribers: atul, tomek, ashoat. · View Herald TranscriptMay 25 2023, 10:17 AM

inka edited the test plan for this revision. (Show Details)May 25 2023, 10:19 AM

inka attached a referenced file: F558835: Screen Recording 2023-05-25 at 16.04.16.mov. (Show Details)

Harbormaster completed remote builds in B19774: Diff 27066.May 25 2023, 10:36 AM

inka requested review of this revision.May 25 2023, 10:36 AM

What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"

Also wondering what happens if there are multiple pages of results loaded and a refresh occurs. Will the refresh "reset" to only showing one page of results? Or will the refresh only refresh the second page of results, or something like that?

inka added a reviewer: rohan.Jun 1 2023, 2:12 AM

In D7981#237198, @ashoat wrote:

What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"

Also wondering what happens if there are multiple pages of results loaded and a refresh occurs. Will the refresh "reset" to only showing one page of results? Or will the refresh only refresh the second page of results, or something like that?

We currently fetch all pinned messages for the thread in one server call (this is to be changed by this issue), so for now they are just all replaced