issue: https://linear.app/comm/issue/ENG-3896/message-pin-view-on-web-refreshes-when-user-navigates-back-and-away
When the user navigates to a different tab / app the connectionStatus is changed to disconnected. This indirectly causes the callFetchPinnedMessages variable in MessageResultsModal to change when the user comes back to comm, which
in turn calls the Effect hook that fetches pinned messages.
Previously in such case we stopped showing the old results, and show only the loading indicator. Now we show the old results and the loading indicator above them, and once the fetch is completed the results are updated.
Some changes to css were made to stop the modal from resizing when the loading indicator appears / disappears (resulting in jumping screen effect).
Details
Details
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/pin_refresh
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
Comment Actions
What happens on a refresh? Wondering if the results get "replaced" after the load is complete, or if they get "merged"
Also wondering what happens if there are multiple pages of results loaded and a refresh occurs. Will the refresh "reset" to only showing one page of results? Or will the refresh only refresh the second page of results, or something like that?
Comment Actions
We currently fetch all pinned messages for the thread in one server call (this is to be changed by this issue), so for now they are just all replaced
Comment Actions
Makes sense to me if the messages all get replaced & a local test of this seemed to work as expected