Page MenuHomePhabricator

[identity] implement addReservedUsername and removeReservedUsername RPCs
ClosedPublic

Authored by varun on Jun 6 2023, 1:29 PM.
Tags
None
Referenced Files
F1695725: D8134.diff
Fri, May 3, 9:03 AM
Unknown Object (File)
Wed, Apr 24, 8:43 AM
Unknown Object (File)
Wed, Apr 24, 8:43 AM
Unknown Object (File)
Wed, Apr 24, 8:43 AM
Unknown Object (File)
Wed, Apr 24, 8:43 AM
Unknown Object (File)
Wed, Apr 24, 8:41 AM
Unknown Object (File)
Feb 27 2024, 1:43 AM
Unknown Object (File)
Feb 27 2024, 1:43 AM
Subscribers

Details

Summary
  1. Check that the caller is Ashoat's keyserver by verifying the signature and validating the message components
  2. Add or delete the username in the request from the reserved usernames DDB table
Test Plan

seeded DDB table with some usernames.
called the remove RPC from Bloom with a username from the table; confirmed that username was deleted from table.
called the add RPC with a new username; confirmed that username was added to table.
called the remove RPC with a new username; got back an error as expected, since username doesn't exist in table
called the add and remove RPCs with an invalid signature; got back an error as expected

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

varun requested review of this revision.Jun 6 2023, 1:47 PM
services/identity/src/client_service.rs
801–810 ↗(On Diff #27511)

still of the opinion we should have a separate add and remove endpoint

now two RPCs, addReservedUsername and removeReservedUsername

varun retitled this revision from [identity] implement UpdateReservedUsernamesList RPC to [identity] implement addReservedUsername and removeReservedUsername RPCs.Jun 16 2023, 12:47 AM
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Jun 16 2023, 5:39 AM