[services-lib] Add is_valid_identifier function
ClosedPublic
Actions

Authored by bartek on Jun 12 2023, 2:34 AM.

Details

Reviewers

• jon
varun
michal
tomek

Commits

rCOMM3166758d98c2: [services-lib] Add is_valid_identifier function

Summary

Part of ENG-3810.
Added a simple function to check if given string doesn't contain any invalid characters.

Test Plan

Unit tests.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Jun 12 2023, 2:34 AM

bartek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJun 12 2023, 2:34 AM

Harbormaster failed remote builds in B20171: Diff 27636!Jun 12 2023, 2:36 AM

bartek added a child revision: D8180: [blob-service] Validate holder and blob_hash inputs.Jun 12 2023, 2:36 AM

bartek published this revision for review.Jun 12 2023, 3:39 AM

• jon accepted this revision.Jun 12 2023, 7:33 AM

This revision is now accepted and ready to land.Jun 12 2023, 7:33 AM

(Shellcheck CI job should pass after pulling in latest changes.)

Rebase. Fix typo

Harbormaster completed remote builds in B20203: Diff 27678.Jun 13 2023, 1:19 AM

Closed by commit rCOMM3166758d98c2: [services-lib] Add is_valid_identifier function (authored by bartek). · Explain WhyJun 13 2023, 9:51 PM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM3166758d98c2: [services-lib] Add is_valid_identifier function.

Revision Contents
Changeset List

Path

Size

services/

comm-services-lib/

src/

lib.rs

1 line

tools.rs

68 lines

Diff 27636

View Options

services/comm-services-lib/src/lib.rs