Page MenuHomePhabricator
Differential D8399

[Keyserver/rust] Ignore debug version of napi build
ClosedPublic
Actions

Authored by • jon on Jun 30 2023, 3:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 4:59 PM
Unknown Object (File)
Sat, May 4, 4:59 PM
Unknown Object (File)
Sat, May 4, 4:58 PM
Unknown Object (File)
Sat, May 4, 4:28 PM
Unknown Object (File)
Sat, May 4, 3:13 PM
Unknown Object (File)
Sat, May 4, 12:07 PM
Unknown Object (File)
Sat, May 4, 12:07 PM
Unknown Object (File)
Fri, May 3, 8:34 PM
View All 68 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM47e3232b9532: [Keyserver/rust] Ignore debug version of napi build
Summary

Avoid the generated output of yarn build

Depends on D8366

Test Plan

N/A

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jun 30 2023, 3:26 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 30 2023, 3:26 PM
• jon added a child revision: D8400: [Keyserver] Apply DB Migrations.Jun 30 2023, 3:27 PM
• jon added a child revision: D8401: [Identity] Allow for setting logging levels through env.
Harbormaster completed remote builds in B20659: Diff 28315.Jun 30 2023, 3:43 PM
• jon requested review of this revision.Jun 30 2023, 3:43 PM
varun accepted this revision.Jul 6 2023, 8:20 AM

how do you generate rust-node-addon.node? i ran yarn build:debug and don't see it

This revision is now accepted and ready to land.Jul 6 2023, 8:20 AM
• jon removed a child revision: D8401: [Identity] Allow for setting logging levels through env.Jul 6 2023, 9:16 AM
• jon added a comment.Jul 6 2023, 9:29 AM

how do you generate rust-node-addon.node? i ran yarn build:debug and don't see it

If you do napi build directly, was running this command because yarn build takes forever.

• jon added a child revision: D8401: [Identity] Allow for setting logging levels through env.Jul 6 2023, 10:17 AM
• jon removed a child revision: D8401: [Identity] Allow for setting logging levels through env.Jul 6 2023, 10:21 AM
Closed by commit rCOMM47e3232b9532: [Keyserver/rust] Ignore debug version of napi build (authored by • jon). · Explain WhyJul 6 2023, 10:22 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM47e3232b9532: [Keyserver/rust] Ignore debug version of napi build.

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
1 line

Diff 28448

View Options

keyserver/addons/rust-node-addon/.gitignore

Loading...