Page MenuHomePhabricator
Differential D8473

[Keyserver/rust] Add publish_prekeys implementation
ClosedPublic
Actions

Authored by • jon on Jul 11 2023, 9:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 18, 1:13 AM
Unknown Object (File)
Sun, Mar 16, 11:14 PM
Unknown Object (File)
Mar 4 2025, 8:35 PM
Unknown Object (File)
Mar 4 2025, 8:35 PM
Unknown Object (File)
Mar 4 2025, 8:35 PM
Unknown Object (File)
Mar 4 2025, 8:35 PM
Unknown Object (File)
Mar 4 2025, 8:35 PM
Unknown Object (File)
Mar 4 2025, 8:35 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM7524181bb2d3: [Keyserver/rust] Add publish_prekeys implementation
Summary

Implement the rust bindings for publishing prekeys to
identity service.

Part of https://linear.app/comm/issue/ENG-3944

Depends on D8464

Test Plan

Tested in a later diff

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• jon created this revision.Jul 11 2023, 9:55 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 11 2023, 9:55 AM
• jon added a child revision: D8474: [Keyserver] Refactor prekey lifecycle logic.Jul 11 2023, 10:00 AM
Harbormaster completed remote builds in B20868: Diff 28588.Jul 11 2023, 10:13 AM
• jon requested review of this revision.Jul 11 2023, 10:13 AM
bartek added inline comments.Jul 11 2023, 10:38 AM
keyserver/addons/rust-node-addon/src/identity_client/prekey.rs
30–38 ↗(On Diff #28588)

I understand that these unwraps are temporary until getCommConfig is implemented

• jon updated this revision to Diff 28594.Jul 11 2023, 10:54 AM

Rebase on other work

• jon updated this revision to Diff 28596.Jul 11 2023, 11:00 AM

Fix accidental rebase error

Harbormaster completed remote builds in B20874: Diff 28594.Jul 11 2023, 11:10 AM
Harbormaster completed remote builds in B20876: Diff 28596.Jul 11 2023, 11:19 AM
varun requested changes to this revision.Jul 11 2023, 2:06 PM
varun added inline comments.
keyserver/addons/rust-node-addon/build.rs
8 ↗(On Diff #28596)

mentioned this in another diff but i think we can just have one .proto file

keyserver/addons/rust-node-addon/rust-binding-types.js
39–45 ↗(On Diff #28596)

these should be camelCase

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs
24–28 ↗(On Diff #28596)

we already have a helper function get_identity_service_channel that does this. can you please take a look at some of the other client methods in rust-node-addon?

34–37 ↗(On Diff #28596)

why do we use append instead of insert?

30–38 ↗(On Diff #28588)

we'll still have to call the parse method then, right?

This revision now requires changes to proceed.Jul 11 2023, 2:06 PM
• jon updated this revision to Diff 28680.Jul 13 2023, 2:09 PM
• jon marked 6 inline comments as done.

Address feedback, refactor auth client into self-contained module

keyserver/addons/rust-node-addon/build.rs
8 ↗(On Diff #28596)

We had a comm discussion, decided to eventually separate the two.

keyserver/addons/rust-node-addon/rust-binding-types.js
39–45 ↗(On Diff #28596)

oops

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs
24–28 ↗(On Diff #28596)

I tried this initially with just trying to pass the interceptor as a function, and it was pretty gnarly with the types, and I chose not to.

However, going the struct + impl route was a lot easier, so done.

34–37 ↗(On Diff #28596)

first example I ran across used it, but insert is a destructive insertion, so it's closer to what I would want anyway.

Thanks

30–38 ↗(On Diff #28588)

we'll still have to call the parse method then, right?

yes, it's because metadata is a MetadataMap<Ascii>, so the utf8 string has to be parsed into just the ascii subset of allowed characters.

I understand that these unwraps are temporary until getCommConfig is implemented

Handling the error is still necessary, just did unwrap() while I had failing tests. I'll do a proper handling function and address this.

Harbormaster completed remote builds in B20926: Diff 28680.Jul 13 2023, 2:29 PM
• jon updated this revision to Diff 28682.Jul 13 2023, 2:48 PM

Improve error handling

Harbormaster completed remote builds in B20928: Diff 28682.Jul 13 2023, 3:05 PM
varun requested changes to this revision.Jul 17 2023, 11:06 PM

it seems like some of my feedback wasn't addressed, maybe a rebase issue?

This revision now requires changes to proceed.Jul 17 2023, 11:06 PM
• jon updated this revision to Diff 28896.Jul 20 2023, 9:39 AM

Apply missed feedback during refactor

Harbormaster completed remote builds in B21091: Diff 28896.Jul 20 2023, 9:57 AM
varun accepted this revision.Jul 22 2023, 10:02 AM
This revision is now accepted and ready to land.Jul 22 2023, 10:02 AM
• jon updated this revision to Diff 28966.Jul 24 2023, 6:35 AM

Rebase on master

• jon edited child revisions, added: D8475: [Keyserver] Refactor identity utilities; removed: D8474: [Keyserver] Refactor prekey lifecycle logic.Jul 24 2023, 6:41 AM
Harbormaster completed remote builds in B21144: Diff 28966.Jul 24 2023, 7:02 AM
Closed by commit rCOMM7524181bb2d3: [Keyserver/rust] Add publish_prekeys implementation (authored by • jon). · Explain WhyAug 8 2023, 7:56 AM
This revision was automatically updated to reflect the committed changes.
• jon added a commit: rCOMM7524181bb2d3: [Keyserver/rust] Add publish_prekeys implementation.
kamil mentioned this in D9106: [keyserver] add missing `napi` annotation.Sep 8 2023, 4:03 AM
kamil mentioned this in rCOMM90b2d6d04eaa: [keyserver] add missing `napi` annotation.Sep 13 2023, 9:09 AM
kamil mentioned this in D9421: [keyserver] cron job to refresh account prekeys.Oct 11 2023, 3:30 AM

Revision Contents
Changeset List

PathSize
keyserver/
addons/
rust-node-addon/
5 lines
9 lines
src/
identity_client/
67 lines
2 lines
41 lines

Diff 29624

View Options

keyserver/addons/rust-node-addon/build.rs

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

keyserver/addons/rust-node-addon/rust-binding-types.js

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

keyserver/addons/rust-node-addon/src/identity_client/auth_client.rs

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm
View Options

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs

Show First 20 Lines • Show All 153 Lines • ▼ Show 20 Lines
class RemoveAllMessagesOperation : public MessageStoreOperationBase { class RemoveAllMessagesOperation : public MessageStoreOperationBase {
public: public:
virtual void execute() override { virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessages(); DatabaseManager::getQueryExecutor().removeAllMessages();
DatabaseManager::getQueryExecutor().removeAllMedia(); DatabaseManager::getQueryExecutor().removeAllMedia();
} }
}; };
class ReplaceMessageThreadsOperation : public MessageStoreOperationBase {
public:
ReplaceMessageThreadsOperation(jsi::Runtime &rt, const jsi::Object &payload)
: msg_threads{} {
auto threads = payload.getProperty(rt, "threads").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < threads.size(rt); idx++) {
auto thread = threads.getValueAtIndex(rt, idx).asObject(rt);
auto thread_id = thread.getProperty(rt, "id").asString(rt).utf8(rt);
auto start_reached = std::stoi(
thread.getProperty(rt, "start_reached").asString(rt).utf8(rt));
auto last_navigated_to = std::stoll(
thread.getProperty(rt, "last_navigated_to").asString(rt).utf8(rt));
auto last_pruned = std::stoll(
thread.getProperty(rt, "last_pruned").asString(rt).utf8(rt));
MessageStoreThread msg_thread = MessageStoreThread{
thread_id, start_reached, last_navigated_to, last_pruned};
this->msg_threads.push_back(msg_thread);
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().replaceMessageStoreThreads(
this->msg_threads);
}
private:
std::vector<MessageStoreThread> msg_threads;
};
class RemoveAllMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeAllMessageStoreThreads();
}
};
class RemoveMessageStoreThreadsOperation : public MessageStoreOperationBase {
public:
RemoveMessageStoreThreadsOperation(
jsi::Runtime &rt,
const jsi::Object &payload)
: thread_ids{} {
auto payload_ids = payload.getProperty(rt, "ids").asObject(rt).asArray(rt);
for (size_t idx = 0; idx < payload_ids.size(rt); idx++) {
this->thread_ids.push_back(
payload_ids.getValueAtIndex(rt, idx).asString(rt).utf8(rt));
}
}
virtual void execute() override {
DatabaseManager::getQueryExecutor().removeMessageStoreThreads(
this->thread_ids);
}
private:
std::vector<std::string> thread_ids;
};
} // namespace comm } // namespace comm