Implement the rust bindings for publishing prekeys to
identity service.
Part of https://linear.app/comm/issue/ENG-3944
Depends on D8464
Details
Details
Tested in a later diff
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| keyserver/addons/rust-node-addon/src/identity_client/prekey.rs | ||
|---|---|---|
| 30–38 ↗ | (On Diff #28588) | I understand that these unwraps are temporary until getCommConfig is implemented |
| keyserver/addons/rust-node-addon/build.rs | ||
|---|---|---|
| 8 ↗ | (On Diff #28596) | mentioned this in another diff but i think we can just have one .proto file |
| keyserver/addons/rust-node-addon/rust-binding-types.js | ||
| 39–45 ↗ | (On Diff #28596) | these should be camelCase |
| keyserver/addons/rust-node-addon/src/identity_client/prekey.rs | ||
| 24–28 ↗ | (On Diff #28596) | we already have a helper function get_identity_service_channel that does this. can you please take a look at some of the other client methods in rust-node-addon? |
| 34–37 ↗ | (On Diff #28596) | why do we use append instead of insert? |
| 30–38 ↗ | (On Diff #28588) | we'll still have to call the parse method then, right? |
Comment Actions
Address feedback, refactor auth client into self-contained module
| keyserver/addons/rust-node-addon/build.rs | ||
|---|---|---|
| 8 ↗ | (On Diff #28596) | We had a comm discussion, decided to eventually separate the two. |
| keyserver/addons/rust-node-addon/rust-binding-types.js | ||
| 39–45 ↗ | (On Diff #28596) | oops |
| keyserver/addons/rust-node-addon/src/identity_client/prekey.rs | ||
| 24–28 ↗ | (On Diff #28596) | I tried this initially with just trying to pass the interceptor as a function, and it was pretty gnarly with the types, and I chose not to. However, going the struct + impl route was a lot easier, so done. |
| 34–37 ↗ | (On Diff #28596) | first example I ran across used it, but insert is a destructive insertion, so it's closer to what I would want anyway. Thanks |
| 30–38 ↗ | (On Diff #28588) |
yes, it's because metadata is a MetadataMap<Ascii>, so the utf8 string has to be parsed into just the ascii subset of allowed characters.
Handling the error is still necessary, just did unwrap() while I had failing tests. I'll do a proper handling function and address this. |