Details

Reviewers

varun
bartek

Commits

rCOMM57cf5dbdec07: [Identity] Allow for setting logging levels through env

Summary

Improve logging, previously only INFO and above
could be emitted. Now you can set debug with RUST_LOG=debug

Depends on D8400

Test Plan

cd services/identity
RUST_LOG=debug cargo run -- server

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jun 30 2023, 10:28 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJun 30 2023, 10:28 PM

Harbormaster completed remote builds in B20661: Diff 28317.Jun 30 2023, 10:58 PM

• jon requested review of this revision.Jun 30 2023, 10:58 PM

bartek added inline comments.Jul 1 2023, 6:12 AM

services/identity/src/client_service.rs
100 ↗	(On Diff #28317)	Nit, I see this cleaner without the blank line
429 ↗	(On Diff #28317)	Isn't this `"user_id and password"`? I don't know how sensitive data this is - It's debug-only log so I assume we don't display it in prod anyway, do we?

ashoat added inline comments.Jul 3 2023, 5:32 PM

services/identity/src/client_service.rs
429 ↗	(On Diff #28317)	Even in debug, I think printing a password to the log isn't great... Imagine somebody uses a real password of theirs in the dev environment. They would be surprised (in a bad way) if they see it printed to the screen I think printing the username here is fine though

• jon edited parent revisions, added: D8400: [Keyserver] Apply DB Migrations; removed: D8399: [Keyserver/rust] Ignore debug version of napi build.Jul 6 2023, 4:16 PM

• jon added a child revision: D8402: [Identity] Fix opaque login.

Address feedback

• jon edited the summary of this revision. (Show Details)Jul 6 2023, 5:21 PM

• jon removed a parent revision: D8399: [Keyserver/rust] Ignore debug version of napi build.

Harbormaster completed remote builds in B20769: Diff 28445.Jul 6 2023, 5:34 PM

varun accepted this revision.Jul 6 2023, 5:56 PM

This revision is now accepted and ready to land.Jul 6 2023, 5:56 PM

bartek accepted this revision.Jul 7 2023, 6:20 AM

Address feedback, fix parent diff

services/identity/src/client_service.rs
429 ↗	(On Diff #28317)	oh sorry, I added this because of the regression in identity service (which had the error message "pakeRegistrationData not found"), I meant to remove it before doing `arc diff`

Harbormaster completed remote builds in B20920: Diff 28674.Jul 13 2023, 4:35 PM

Rebase on master

This revision was landed with ongoing or failed builds.Jul 17 2023, 2:39 AM

Closed by commit rCOMM57cf5dbdec07: [Identity] Allow for setting logging levels through env. · Explain Why

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM57cf5dbdec07: [Identity] Allow for setting logging levels through env.

Harbormaster completed remote builds in B20956: Diff 28712.Jul 17 2023, 8:00 AM

[Identity] Allow for setting logging levels through env
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 28719

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/src/client_service.rs

services/identity/src/main.rs

[Identity] Allow for setting logging levels through envClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 28719

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/src/client_service.rs

services/identity/src/main.rs

[Identity] Allow for setting logging levels through env
ClosedPublic
Actions

Revision Contents
Changeset List