Differential D9106

[keyserver] add missing `napi` annotation
ClosedPublic
Actions

Authored by kamil on Sep 8 2023, 4:03 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 27, 12:01 PM

	Unknown Object (File)
	Sun, Mar 16, 11:14 PM

	Unknown Object (File)
	Thu, Mar 13, 5:51 AM

	Unknown Object (File)
	Tue, Mar 4, 8:35 PM

	Unknown Object (File)
	Tue, Mar 4, 8:35 PM

	Unknown Object (File)
	Tue, Mar 4, 8:35 PM

	Unknown Object (File)
	Tue, Mar 4, 8:34 PM

	Unknown Object (File)
	Tue, Mar 4, 8:27 PM

Subscribers

Details

Reviewers

michal
bartek
varun

Commits

rCOMM90b2d6d04eaa: [keyserver] add missing `napi` annotation

Summary

This fixes problem with accessing this from JS, introduced in D8473.

Test Plan

Test if this method is accessible via JS

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Sep 8 2023, 4:03 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptSep 8 2023, 4:03 AM

kamil added a child revision: D8476: [Keyserver] Publish prekeys to identity service for cron job.Sep 8 2023, 4:10 AM

rebase

Harbormaster failed remote builds in B22439: Diff 30855!Sep 8 2023, 4:18 AM

kamil published this revision for review.Sep 8 2023, 4:31 AM

Harbormaster completed remote builds in B22441: Diff 30857.Sep 8 2023, 4:33 AM

kamil mentioned this in D8476: [Keyserver] Publish prekeys to identity service for cron job.Sep 8 2023, 4:34 AM

varun accepted this revision.Sep 8 2023, 5:06 AM

This revision is now accepted and ready to land.Sep 8 2023, 5:06 AM

Closed by commit rCOMM90b2d6d04eaa: [keyserver] add missing `napi` annotation (authored by kamil). · Explain WhySep 13 2023, 9:09 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM90b2d6d04eaa: [keyserver] add missing `napi` annotation.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

1 line

Diff 31064

keyserver/addons/rust-node-addon/src/identity_client/prekey.rs

	Show All 37 Lines
	)			)

	if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")			if(${CMAKE_CURRENT_SOURCE_DIR} STREQUAL "/transferred/tunnelbroker")
	# Inside the docker build contex			# Inside the docker build contex
	set(_proto_path "grpc")			set(_proto_path "grpc")
	set(_shared_path "../shared")			set(_shared_path "../shared")
	else()			else()
	# Inside repo			# Inside repo
	set(_proto_path "../../native/cpp/CommonCpp/grpc")
	set(_shared_path "../../shared")			set(_shared_path "../../shared")
				set(_proto_path "../../shared/protos")
	endif()			endif()

	# Shared Comm protos			# Shared Comm protos
	add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}			add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/${_proto_path}
	${CMAKE_CURRENT_BINARY_DIR}/protos			${CMAKE_CURRENT_BINARY_DIR}/protos
	EXCLUDE_FROM_ALL			EXCLUDE_FROM_ALL
	)			)

	▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines