[Services-test/identity] Refactor create_device
ClosedPublic
Actions

Authored by • jon on Jul 10 2023, 6:28 AM.

Details

Reviewers

bartek
varun

Commits

rCOMM921c2da41054: [Services-test/identity] Refactor create_device

Summary

This function is useful for a lot of scenarios,
make into it's own function, to allow for it to be used
in many locations

In support for testing RefreshUserPreKey:

https://linear.app/comm/issue/ENG-3942

Depends on D8434

Test Plan

Start docker, localstack, run terraform

cd services/commtest
cargo test --test identity_access_tokens_tests

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• jon created this revision.Jul 10 2023, 6:28 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 10 2023, 6:28 AM

• jon added a child revision: D8464: [Identity] Implement RefreshUserPreKey.Jul 10 2023, 6:30 AM

Harbormaster completed remote builds in B20845: Diff 28550.Jul 10 2023, 6:51 AM

• jon requested review of this revision.Jul 10 2023, 6:51 AM

bartek accepted this revision.Jul 11 2023, 10:22 AM

This revision is now accepted and ready to land.Jul 11 2023, 10:22 AM

• jon added inline comments.Jul 13 2023, 10:05 AM

services/commtest/src/identity/device.rs
96–103 ↗	(On Diff #28550)	kind of annoying that phabricator is showing this as a copy + delete, instead of a partial add.

Rebase on master

Harbormaster completed remote builds in B21142: Diff 28964.Jul 24 2023, 6:51 AM

Rebase on master

Harbormaster completed remote builds in B21570: Diff 29594.Aug 7 2023, 8:51 AM

Closed by commit rCOMM921c2da41054: [Services-test/identity] Refactor create_device (authored by • jon). · Explain WhyAug 8 2023, 7:56 AM

This revision was automatically updated to reflect the committed changes.

• jon added a commit: rCOMM921c2da41054: [Services-test/identity] Refactor create_device.

Revision Contents
Changeset List

Path

Size

services/

commtest/

	src/	identity/
		tests/

	device.rs
	identity_access_tokens_tests.rs

61 lines

src/

identity/

mod.rs

1 line

lib.rs

1 line

tests/

identity_access_tokens_tests.rs

95 lines

Diff 29622

View Options

services/commtest/src/identity/device.rs

View Options

services/commtest/src/identity/mod.rs

View Options

services/commtest/src/lib.rs

View Options

services/commtest/tests/identity_access_tokens_tests.rs

[Services-test/identity] Refactor create_deviceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29622

services/commtest/src/identity/device.rs

services/commtest/src/identity/mod.rs

services/commtest/src/lib.rs

services/commtest/tests/identity_access_tokens_tests.rs

[Services-test/identity] Refactor create_device
ClosedPublic
Actions

Revision Contents
Changeset List