Page MenuHomePhabricator
Differential D8559

[web] implement functions to import/export database content
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 7:02 AM.
Tags
None
Referenced Files
F2157209: D8559.id29126.diff
Mon, Jul 1, 1:23 AM
F2157208: D8559.id29119.diff
Mon, Jul 1, 1:23 AM
F2157207: D8559.id29000.diff
Mon, Jul 1, 1:23 AM
F2157205: D8559.id28834.diff
Mon, Jul 1, 1:23 AM
F2157174: D8559.diff
Mon, Jul 1, 1:19 AM
F2151193: D8559.id.diff
Sun, Jun 30, 12:13 PM
Unknown Object (File)
Wed, Jun 26, 3:40 PM
Unknown Object (File)
Wed, Jun 26, 2:57 AM
View All 93 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM2c4ed0da9cf0: [web] implement functions to import/export database content
Summary

This is using Emscripten virtual file API.

Gets/puts file content on which the native module operates.

Only worker (one thread) operates on file using synchronous API - there should be no problems with locks/parallel access.

Test Plan

Tests.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 19 2023, 7:02 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 7:02 AM
kamil added a child revision: D8560: [web] switch code from `sql.js` API to `.wasm` database module.Jul 19 2023, 7:05 AM
Harbormaster completed remote builds in B21038: Diff 28834.Jul 19 2023, 7:50 AM
kamil published this revision for review.Jul 19 2023, 9:10 AM
kamil edited the summary of this revision. (Show Details)
michal accepted this revision.Jul 21 2023, 6:31 AM
This revision is now accepted and ready to land.Jul 21 2023, 6:31 AM
kamil updated this revision to Diff 29000.Jul 25 2023, 2:03 AM

rebase

kamil edited parent revisions, added: D8611: [web] implement function to clear database content; removed: D8558: [web] rework database module tests to use CommQueryExecutor.Jul 25 2023, 2:03 AM
kamil added a child revision: D8558: [web] rework database module tests to use CommQueryExecutor.
kamil removed a child revision: D8560: [web] switch code from `sql.js` API to `.wasm` database module.Jul 25 2023, 2:14 AM
Harbormaster failed remote builds in B21167: Diff 29000!Jul 25 2023, 2:44 AM
Harbormaster completed remote builds in B21167: Diff 29000.Jul 27 2023, 5:00 AM
kamil edited the summary of this revision. (Show Details)Jul 27 2023, 5:09 AM
kamil updated this revision to Diff 29119.Jul 27 2023, 5:10 AM
kamil edited the summary of this revision. (Show Details)

CI

Harbormaster completed remote builds in B21269: Diff 29119.Jul 27 2023, 5:27 AM
Closed by commit rCOMM2c4ed0da9cf0: [web] implement functions to import/export database content (authored by kamil). · Explain WhyJul 27 2023, 5:40 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM2c4ed0da9cf0: [web] implement functions to import/export database content.
kamil added a child revision: D8560: [web] switch code from `sql.js` API to `.wasm` database module.Jul 27 2023, 7:18 AM
kamil removed a child revision: D8560: [web] switch code from `sql.js` API to `.wasm` database module.Jul 27 2023, 7:22 AM
ashoat added a comment.Jul 28 2023, 7:53 AM

Minor note – the filename worker-crypto-utlis.test.js has a typo

kamil mentioned this in D8653: [web] fix typo in crypto tests filename.Jul 28 2023, 9:33 AM
kamil added a comment.Jul 28 2023, 9:58 AM
In D8559#255126, @ashoat wrote:

Minor note – the filename worker-crypto-utlis.test.js has a typo

Thanks for catching it, fixed in D8653

kamil mentioned this in rCOMM4ca10823982e: [web] fix typo in crypto tests filename.Jul 28 2023, 10:10 AM

Revision Contents
Changeset List

PathSize
web/
database/
utils/
23 lines
61 lines

Diff 29126

View Options

web/database/utils/db-utils.js

Loading...
View Options

web/database/utils/worker-crypto-utlis.test.js

Loading...