On web, we will need to pass database path (path to virtual file in memory) from JS, and the best way will be to achieve this via constructor.
Depends on D8550
Details
Details
N/A
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 942–945 ↗ | (On Diff #28825) | Not really sure what the best practices for this are in c++, but can we do sth like call the arg-less constructor, from another constructor instead of calling migrate? |
| native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
|---|---|---|
| 942–945 ↗ | (On Diff #28825) | I think we can do sth like: SQLiteQueryExecutor::SQLiteQueryExecutor()
: SQLiteQueryExecutor(*default path*) {}
SQLiteQueryExecutor::SQLiteQueryExecutor(std::string sqliteFilePath) {
SQLiteQueryExecutor::sqliteFilePath = sqliteFilePath;
SQLiteQueryExecutor::migrate();
}but we do not have a default path and this is less readable |