[native] hide native-specific code
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 5:33 AM.

Details

Reviewers

michal
tomek
• jon

Commits

rCOMMbe18f17c10e2: [native] hide native-specific code

Summary

Hiding code that will require adding to web dependencies like olm.h or SecureStore implementation.

NOTE: Using #ifdef is not the cleanest and this will be refactored, native-only code will be extracted, but this requires breaking changes and will take some review cycles, that being said I want to port this on web and make it workable (this is the goal) and right after I will put up diffs with refactor.

Depends on D8549

Test Plan

yarn build-db-wasm

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 19 2023, 5:33 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 5:33 AM

kamil added a child revision: D8551: [native] overload `SQLiteQueryExecutor` constructor.Jul 19 2023, 5:36 AM

Harbormaster completed remote builds in B21027: Diff 28823.Jul 19 2023, 5:51 AM

kamil published this revision for review.Jul 19 2023, 9:00 AM

Makes sense as a transitional step. But I wonder if there is a better solution which someone else might know.

Probably the "better solution" is the refactor @kamil is doing right now, but it makes sense to me to sequence it later, so we have something working on web already

This revision is now accepted and ready to land.Jul 21 2023, 4:49 AM

trigger Emscripten pipeline

Harbormaster completed remote builds in B21262: Diff 29106.Jul 27 2023, 4:56 AM

Closed by commit rCOMMbe18f17c10e2: [native] hide native-specific code (authored by kamil). · Explain WhyJul 27 2023, 5:06 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMbe18f17c10e2: [native] hide native-specific code.