Page MenuHomePhabricator

[native] hide native-specific code
ClosedPublic

Authored by kamil on Jul 19 2023, 5:33 AM.
Tags
None
Referenced Files
F3174992: D8550.diff
Thu, Nov 7, 7:31 PM
Unknown Object (File)
Fri, Nov 1, 3:53 PM
Unknown Object (File)
Sat, Oct 26, 1:59 AM
Unknown Object (File)
Tue, Oct 15, 6:40 PM
Unknown Object (File)
Tue, Oct 15, 1:23 AM
Unknown Object (File)
Sun, Oct 13, 11:55 AM
Unknown Object (File)
Fri, Oct 11, 8:40 AM
Unknown Object (File)
Tue, Oct 8, 9:52 PM
Subscribers

Details

Summary

Hiding code that will require adding to web dependencies like olm.h or SecureStore implementation.

NOTE: Using #ifdef is not the cleanest and this will be refactored, native-only code will be extracted, but this requires breaking changes and will take some review cycles, that being said I want to port this on web and make it workable (this is the goal) and right after I will put up diffs with refactor.

Depends on D8549

Test Plan

yarn build-db-wasm

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 19 2023, 9:00 AM

Makes sense as a transitional step. But I wonder if there is a better solution which someone else might know.

Probably the "better solution" is the refactor @kamil is doing right now, but it makes sense to me to sequence it later, so we have something working on web already

This revision is now accepted and ready to land.Jul 21 2023, 4:49 AM

trigger Emscripten pipeline

This revision was automatically updated to reflect the committed changes.