Page MenuHomePhabricator
Differential D8553

[web] add SQLiteQueryExecutor bindings and type
ClosedPublic
Actions

Authored by kamil on Jul 19 2023, 6:49 AM.
Tags
None
Referenced Files
F2157200: D8553.id29116.diff
Mon, Jul 1, 1:23 AM
F2157176: D8553.diff
Mon, Jul 1, 1:19 AM
Unknown Object (File)
Tue, Jun 25, 2:57 PM
Unknown Object (File)
Mon, Jun 24, 3:01 AM
Unknown Object (File)
Sat, Jun 22, 2:07 AM
Unknown Object (File)
Mon, Jun 3, 8:43 PM
Unknown Object (File)
May 30 2024, 3:50 AM
Unknown Object (File)
May 26 2024, 5:20 PM
View All 43 Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
• jon
Commits
rCOMM8e34b7732528: [web] add SQLiteQueryExecutor bindings and type
Summary

Binds SQLiteQueryExecutor to WASM module and calls its constructor.

Depends on D8552, D8547, D8489, D8472

Test Plan

Call constructor and logs on worker console should be the same as in native's migration code.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 19 2023, 6:49 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 6:49 AM
kamil updated this revision to Diff 28828.Jul 19 2023, 6:51 AM

fix type name

kamil added a child revision: D8554: [web] rework report tests to use CommQueryExecutor.Jul 19 2023, 6:53 AM
Harbormaster completed remote builds in B21031: Diff 28827.Jul 19 2023, 7:07 AM
Harbormaster completed remote builds in B21032: Diff 28828.
kamil published this revision for review.Jul 19 2023, 9:01 AM
kamil planned changes to this revision.Jul 19 2023, 9:04 AM

actually, types are not accurate enough

kamil updated this revision to Diff 28894.Jul 20 2023, 8:47 AM

improve type

kamil mentioned this in D8548: [web] Add web Logger implementation.Jul 20 2023, 9:00 AM
Harbormaster completed remote builds in B21089: Diff 28894.Jul 20 2023, 9:05 AM
michal accepted this revision.Jul 21 2023, 5:58 AM
This revision is now accepted and ready to land.Jul 21 2023, 5:58 AM
kamil added a child revision: D8611: [web] implement function to clear database content.Jul 25 2023, 2:01 AM
kamil removed a child revision: D8554: [web] rework report tests to use CommQueryExecutor.Jul 25 2023, 2:07 AM
kamil updated this revision to Diff 29107.Jul 27 2023, 4:46 AM

trigger Emscripten pipeline

Harbormaster completed remote builds in B21263: Diff 29107.Jul 27 2023, 5:03 AM
Closed by commit rCOMM8e34b7732528: [web] add SQLiteQueryExecutor bindings and type (authored by kamil). · Explain WhyJul 27 2023, 5:06 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM8e34b7732528: [web] add SQLiteQueryExecutor bindings and type.

Revision Contents
Changeset List

Diff 29116

View Options

web/cpp/SQLiteQueryExecutorBindings.cpp

Loading...
View Options

web/database/_generated/comm-query-executor.js

Loading...
View Options

web/database/_generated/comm_query_executor.wasm

Loading...
View Options

web/database/types/module.js

Loading...
View Options

web/database/types/sqlite-query-executor.js

Loading...
View Options

web/scripts/run_emscripten.sh

Loading...