Details

Reviewers

michal
tomek
• jon

Commits

rCOMM8e34b7732528: [web] add SQLiteQueryExecutor bindings and type

Summary

Binds SQLiteQueryExecutor to WASM module and calls its constructor.

Depends on D8552, D8547, D8489, D8472

Test Plan

Call constructor and logs on worker console should be the same as in native's migration code.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 19 2023, 1:49 PM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 19 2023, 1:49 PM

fix type name

kamil added a child revision: D8554: [web] rework report tests to use CommQueryExecutor.Jul 19 2023, 1:53 PM

Harbormaster completed remote builds in B21031: Diff 28827.Jul 19 2023, 2:07 PM

Harbormaster completed remote builds in B21032: Diff 28828.

kamil published this revision for review.Jul 19 2023, 4:01 PM

actually, types are not accurate enough

improve type

kamil mentioned this in D8548: [web] Add web Logger implementation.Jul 20 2023, 4:00 PM

Harbormaster completed remote builds in B21089: Diff 28894.Jul 20 2023, 4:05 PM

michal accepted this revision.Jul 21 2023, 12:58 PM

This revision is now accepted and ready to land.Jul 21 2023, 12:58 PM

kamil added a child revision: D8611: [web] implement function to clear database content.Jul 25 2023, 9:01 AM

kamil removed a child revision: D8554: [web] rework report tests to use CommQueryExecutor.Jul 25 2023, 9:07 AM

trigger Emscripten pipeline

Harbormaster completed remote builds in B21263: Diff 29107.Jul 27 2023, 12:03 PM

Closed by commit rCOMM8e34b7732528: [web] add SQLiteQueryExecutor bindings and type. · Explain WhyJul 27 2023, 12:06 PM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM8e34b7732528: [web] add SQLiteQueryExecutor bindings and type.

[web] add SQLiteQueryExecutor bindings and type
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 29116

web/cpp/SQLiteQueryExecutorBindings.cpp

web/database/_generated/comm-query-executor.js

web/database/_generated/comm_query_executor.wasm

web/database/types/module.js

web/database/types/sqlite-query-executor.js

web/scripts/run_emscripten.sh

[web] add SQLiteQueryExecutor bindings and typeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 29116

web/cpp/SQLiteQueryExecutorBindings.cpp

web/database/_generated/comm-query-executor.js

web/database/_generated/comm_query_executor.wasm

web/database/types/module.js

web/database/types/sqlite-query-executor.js

web/scripts/run_emscripten.sh

[web] add SQLiteQueryExecutor bindings and type
ClosedPublic
Actions

Revision Contents
Changeset List