[nix] Enable C++17 support for Emscripten
ClosedPublic
Actions

Authored by kamil on Jul 12 2023, 6:18 AM.

Details

Reviewers

michal
tomek
• jon

Commits

rCOMM21bb64c23e31: [nix] Enable C++17 support for Emscripten

Summary

Emscripten is coupled with clang version, according to clang docs C++17 starts from Clang 5.0, while we are using Clang 14.0.6 so should be safe.

Depends on D8487

Test Plan

Run script

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jul 12 2023, 6:18 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJul 12 2023, 6:18 AM

kamil added inline comments.Jul 12 2023, 6:19 AM

web/scripts/run_emscripten.sh
102 ↗	(On Diff #28634)	this line causing hiding this file by phabricator, so adding a comment to show content

kamil added a child revision: D8489: [native] replace `uint` with `unsigned int`.Jul 12 2023, 6:21 AM

Harbormaster completed remote builds in B20903: Diff 28634.Jul 12 2023, 6:35 AM

kamil published this revision for review.Jul 12 2023, 7:36 AM

Are we already explicitly using c++17 in native (not c++14 with extensions for 17)? If not it would be good to use it.

This revision is now accepted and ready to land.Jul 14 2023, 2:26 AM

In D8488#250674, @michal wrote:

Are we already explicitly using c++17 in native (not c++14 with extensions for 17)?

I think so

Closed by commit rCOMM21bb64c23e31: [nix] Enable C++17 support for Emscripten (authored by kamil). · Explain WhyJul 20 2023, 6:56 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM21bb64c23e31: [nix] Enable C++17 support for Emscripten.

Revision Contents
Changeset List

Path

Size

web/

scripts/

run_emscripten.sh

Diff 28889

View Options

web/scripts/run_emscripten.sh

[nix] Enable C++17 support for EmscriptenClosedPublicActions