Page MenuHomePhabricator

[web] implement function to clear database content
ClosedPublic

Authored by kamil on Jul 25 2023, 2:01 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 3:53 PM
Unknown Object (File)
Sat, Oct 26, 1:58 AM
Unknown Object (File)
Tue, Oct 15, 11:22 AM
Unknown Object (File)
Oct 2 2024, 4:16 AM
Unknown Object (File)
Sep 28 2024, 1:55 AM
Unknown Object (File)
Sep 28 2024, 1:54 AM
Unknown Object (File)
Sep 28 2024, 1:54 AM
Unknown Object (File)
Sep 28 2024, 1:54 AM
Subscribers

Details

Summary

Sometimes we might want to manually delete file and destruct object in runtime. Otherwise, Emscripten will use reference counting to destruct objects.

Depends on D8553

Test Plan

Tests in D8558.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jul 25 2023, 2:18 AM
kamil added inline comments.
web/database/utils/db-utils.js
20–21 ↗(On Diff #28999)

I think this order is better to first take off the lock from the file by destructing the class which is using it, then delete it.

The entire API is synchronous so should be safe.

This revision is now accepted and ready to land.Jul 25 2023, 6:16 AM