Page MenuHomePhabricator
Differential D8611

[web] implement function to clear database content
ClosedPublic
Actions

Authored by kamil on Jul 25 2023, 2:01 AM.
Tags
None
Referenced Files
F5117537: D8611.id.diff
Wed, Apr 2, 7:33 PM
Unknown Object (File)
Tue, Apr 1, 9:58 PM
Unknown Object (File)
Thu, Mar 20, 9:49 PM
Unknown Object (File)
Thu, Mar 20, 3:14 AM
Unknown Object (File)
Wed, Mar 19, 3:37 PM
Unknown Object (File)
Sun, Mar 16, 1:51 PM
Unknown Object (File)
Thu, Mar 13, 6:35 PM
Unknown Object (File)
Thu, Mar 13, 6:35 PM
View All Files
Subscribers
ashoat

Details

Reviewers
michal
tomek
Commits
rCOMM6bd9bba33bc9: [web] implement function to clear database content
Summary

Sometimes we might want to manually delete file and destruct object in runtime. Otherwise, Emscripten will use reference counting to destruct objects.

Depends on D8553

Test Plan

Tests in D8558.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jul 25 2023, 2:01 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJul 25 2023, 2:01 AM
kamil added a child revision: D8559: [web] implement functions to import/export database content.Jul 25 2023, 2:03 AM
kamil published this revision for review.Jul 25 2023, 2:18 AM
kamil added inline comments.
web/database/utils/db-utils.js
20–21 ↗(On Diff #28999)

I think this order is better to first take off the lock from the file by destructing the class which is using it, then delete it.

The entire API is synchronous so should be safe.

Harbormaster completed remote builds in B21166: Diff 28999.Jul 25 2023, 2:20 AM
michal accepted this revision.Jul 25 2023, 6:16 AM
This revision is now accepted and ready to land.Jul 25 2023, 6:16 AM
kamil updated this revision to Diff 29117.Jul 27 2023, 5:07 AM

reabse

Harbormaster completed remote builds in B21267: Diff 29117.Jul 27 2023, 5:26 AM
Closed by commit rCOMM6bd9bba33bc9: [web] implement function to clear database content (authored by kamil). · Explain WhyJul 27 2023, 5:39 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM6bd9bba33bc9: [web] implement function to clear database content.

Revision Contents
Changeset List

PathSize
web/
database/
types/
4 lines
utils/
18 lines

Diff 29124

View Options

web/database/types/sqlite-query-executor.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;
View Options

web/database/utils/db-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { Switch, Text, View } from 'react-native'; import { Alert, Switch, Text, View } from 'react-native';
import { ScrollView } from 'react-native-gesture-handler'; import { ScrollView } from 'react-native-gesture-handler';
import { useDispatch } from 'react-redux'; import { useDispatch } from 'react-redux';
import { getMessageForException } from 'lib/utils/errors.js';
import { entries } from 'lib/utils/objects.js';
import { useClientBackup } from '../backup/use-client-backup.js';
import Button from '../components/button.react.js';
import { setLocalSettingsActionType } from '../redux/action-types.js'; import { setLocalSettingsActionType } from '../redux/action-types.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
import { useStyles } from '../themes/colors.js'; import { useColors, useStyles } from '../themes/colors.js';
// eslint-disable-next-line no-unused-vars // eslint-disable-next-line no-unused-vars
function BackupMenu(props: { ... }): React.Node { function BackupMenu(props: { ... }): React.Node {
const styles = useStyles(unboundStyles); const styles = useStyles(unboundStyles);
const dispatch = useDispatch(); const dispatch = useDispatch();
const colors = useColors();
const userStore = useSelector(state => state.userStore);
const isBackupEnabled = useSelector( const isBackupEnabled = useSelector(
state => state.localSettings.isBackupEnabled, state => state.localSettings.isBackupEnabled,
); );
const { restoreBackupProtocol } = useClientBackup();
const testRestore = React.useCallback(async () => {
let message;
try {
const result = await restoreBackupProtocol({ userStore });
message = entries(result)
.map(([key, value]) => `${key}: ${String(value)}`)
.join('\n');
} catch (e) {
console.error(`Backup uploading error: ${e}`);
message = `Backup restore error: ${String(getMessageForException(e))}`;
}
Alert.alert('Restore protocol result', message);
}, [restoreBackupProtocol, userStore]);
const onBackupToggled = React.useCallback( const onBackupToggled = React.useCallback(
value => { value => {
dispatch({ dispatch({
type: setLocalSettingsActionType, type: setLocalSettingsActionType,
payload: { isBackupEnabled: value }, payload: { isBackupEnabled: value },
}); });
}, },
[dispatch], [dispatch],
); );
return ( return (
<ScrollView <ScrollView
contentContainerStyle={styles.scrollViewContentContainer} contentContainerStyle={styles.scrollViewContentContainer}
style={styles.scrollView} style={styles.scrollView}
> >
<Text style={styles.header}>SETTINGS</Text> <Text style={styles.header}>SETTINGS</Text>
<View style={styles.section}> <View style={styles.section}>
<View style={styles.submenuButton}> <View style={styles.submenuButton}>
<Text style={styles.submenuText}>Toggle automatic backup</Text> <Text style={styles.submenuText}>Toggle automatic backup</Text>
<Switch value={isBackupEnabled} onValueChange={onBackupToggled} /> <Switch value={isBackupEnabled} onValueChange={onBackupToggled} />
</View> </View>
</View> </View>
<Text style={styles.header}>ACTIONS</Text>
<View style={styles.section}>
<Button
onPress={testRestore}
style={styles.row}
iosFormat="highlight"
iosHighlightUnderlayColor={colors.panelIosHighlightUnderlay}
iosActiveOpacity={0.85}
>
<Text style={styles.submenuText}>Test backup restore protocol</Text>
</Button>
</View>
</ScrollView> </ScrollView>
); );
} }
const unboundStyles = { const unboundStyles = {
scrollViewContentContainer: { scrollViewContentContainer: {
paddingTop: 24, paddingTop: 24,
}, },
Show All 21 Lines submenuButton: {
paddingVertical: 10, paddingVertical: 10,
alignItems: 'center', alignItems: 'center',
}, },
submenuText: { submenuText: {
color: 'panelForegroundLabel', color: 'panelForegroundLabel',
flex: 1, flex: 1,
fontSize: 16, fontSize: 16,
}, },
row: {
flexDirection: 'row',
justifyContent: 'space-between',
paddingHorizontal: 24,
paddingVertical: 14,
},
}; };
export default BackupMenu; export default BackupMenu;