Details
Details
- Reviewers
varun • jon - Commits
- rCOMMcb9abbe8c9c5: [services][terraform] Add Identity service
It's already deployed to production
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| services/terraform/remote/service_identity.tf | ||
|---|---|---|
| 40 ↗ | (On Diff #29239) | Wrapping this as nonsensitive lets us see TF plan diffs of other fields of this JSON. Otherwise, the whole container_definitions value would be marked as sensitive and redacted in the plan view. As long as we do terraform actions locally, this isn't a security issue. The main goal of storing this value as secret is to hide it from being exposed publicly in the git repo. |
| services/terraform/remote/service_identity.tf | ||
|---|---|---|
| 40 ↗ | (On Diff #29239) | do we need to add anything to the nix_services_deployment doc explaining how to provide this value? |
| services/terraform/remote/service_identity.tf | ||
|---|---|---|
| 40 ↗ | (On Diff #29239) | Updating docs is on my agenda, but I've started with Notion docs and also want to demo the workflow during office hours to give some context. |