[services][terraform] Add default ManagedBy tag to all resources
ClosedPublic
Actions

Authored by bartek on Jul 19 2023, 9:32 AM.

Details

Reviewers

• jon
varun
michal

Commits

rCOMM6836b55b8fd2: [services][terraform] Add default ManagedBy tag to all resources

Summary

Set up a default tag ManagedBy = Terraform to all resources created by Terraform. This will allow us to identify resources created by Terraform and distinguish them from resources created manually.

Depends on D8570

Test Plan

terraform plan shows that the tag will be added to dynamodb tables and s3 buckets.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 19 2023, 9:32 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2023, 9:32 AM

Harbormaster completed remote builds in B21051: Diff 28847.Jul 19 2023, 10:00 AM

bartek published this revision for review.Jul 19 2023, 10:37 AM

• jon requested changes to this revision.Jul 19 2023, 11:41 AM

• jon added inline comments.

services/terraform/remote/main.tf
16 ↗	(On Diff #28847)	should we stick to snake case? seems odd to intersperse title case here

This revision now requires changes to proceed.Jul 19 2023, 11:41 AM

bartek planned changes to this revision.Jul 19 2023, 11:56 AM

bartek added inline comments.

services/terraform/remote/main.tf
16 ↗	(On Diff #28847)	Initially I thought this is AWS convention to use `PascalCase` but now I took another look and see they mix conventions so I'm okay with snake_case