Differential D8582

[services][terraform] Import VPC
ClosedPublic
Actions

Authored by bartek on Jul 20 2023, 6:45 AM.

Tags

None

Referenced Files

None

Subscribers

Details

Reviewers

• jon
varun
michal

Commits

rCOMMf22fd6f6890b: [services][terraform] Import VPC

Summary

Imported our VPC configuration to Terraform.
Imported it as-is, didn't change anything in AWS.

Depends on D8571

Test Plan

Terraform plan results in no differences between current state and remote.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 20 2023, 6:45 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 20 2023, 6:45 AM

Harbormaster completed remote builds in B21078: Diff 28880.Jul 20 2023, 7:03 AM

bartek added a child revision: D8583: [services][terraform] Set up ECS cluster.Jul 20 2023, 11:52 AM

bartek published this revision for review.Jul 20 2023, 11:56 AM

bartek added inline comments.

services/terraform/remote/aws_vpc.tf
45–49 ↗	(On Diff #28880)	I'm not confident enough to assign them right now

varun accepted this revision.Jul 25 2023, 2:33 PM

This revision is now accepted and ready to land.Jul 25 2023, 2:33 PM

• jon accepted this revision.Jul 25 2023, 2:34 PM

Closed by commit rCOMMf22fd6f6890b: [services][terraform] Import VPC. · Explain WhyJul 31 2023, 8:05 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMf22fd6f6890b: [services][terraform] Import VPC.

Revision Contents
Changeset List

Path

Size

services/

terraform/

remote/

61 lines

Diff 29244

services/terraform/remote/aws_vpc.tf

Loading...