Page MenuHomePhabricator

[services][terraform] Create remote config
ClosedPublic

Authored by bartek on Jul 19 2023, 9:20 AM.
Tags
None
Referenced Files
F2173636: D8568.diff
Tue, Jul 2, 10:32 PM
Unknown Object (File)
Fri, Jun 28, 11:31 AM
Unknown Object (File)
Tue, Jun 25, 6:01 PM
Unknown Object (File)
Mon, Jun 24, 11:50 PM
Unknown Object (File)
Sun, Jun 23, 9:22 PM
Unknown Object (File)
Sun, Jun 23, 3:45 PM
Unknown Object (File)
Tue, Jun 18, 3:31 PM
Unknown Object (File)
Tue, Jun 18, 3:31 PM
Subscribers

Details

Summary

Initialized a basic terraform configuration for the remote state. The state will be stored in a S3 bucket in the near future.

Depends on D8567

Test Plan

None yet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Jul 19 2023, 10:34 AM
bartek added inline comments.
services/terraform/remote/main.tf
1–3 ↗(On Diff #28844)

This change is temporary, but I can resign from committing this if told not to.
I use locally AWS_PROFILE=comm so it's convenient for me.

In the final version we want to have a better way of managing staging/prod terraform credentials, cc @jon

services/terraform/remote/main.tf
1–3 ↗(On Diff #28844)

I would prefer dev, staging, prod. cc @varun for thoughts

varun added inline comments.
services/terraform/remote/main.tf
1–3 ↗(On Diff #28844)

i like jon's suggestion

This revision is now accepted and ready to land.Jul 23 2023, 8:41 AM
services/terraform/remote/main.tf
1–3 ↗(On Diff #28844)

I'll delete this variable - We can use the AWS_PROFILE env var which does the same

In the end, I'd like to have the approach described here: https://linear.app/comm/issue/ENG-3549#comment-25a016f4

Remove aws_profile variable

This revision was automatically updated to reflect the committed changes.