[services][terraform] Import shared resources
ClosedPublic
Actions

Authored by bartek on Jul 19 2023, 9:30 AM.

Details

Reviewers

• jon
varun
michal

Commits

rCOMM39966ec7ebcf: [services][terraform] Import shared resources

Summary

When trying to sync remote state with local terraform, I discovered several inconsistencies bethween them.
I needed to make adjustments in the terraform to match local state.
Introduced a is_dev variable to switch betweeen these two.

I don't know which resources are "correct" so I kept the remote state untouched.
Cc @jon, @varun

Depends on D8568

Test Plan

terraform plan in both dev/ and remote/ gives no changes after importing resources.

Used this imports file: imports.tf

note that I use import blocks which require Terraform 1.5 (the Nix one is 1.3)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Jul 19 2023, 9:30 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 19 2023, 9:30 AM

bartek added a child revision: D8571: [services][terraform] Add default ManagedBy tag to all resources.Jul 19 2023, 9:32 AM

Harbormaster completed remote builds in B21050: Diff 28846.Jul 19 2023, 9:49 AM

The purpose of this diff is to decide which DDB tables are actually used and what their config should be. Then I'll apply these changes.

• jon requested changes to this revision.Jul 19 2023, 11:39 AM

• jon added inline comments.

services/terraform/modules/shared/dynamodb.tf
5–6 ↗	(On Diff #28846)	potentially dumb question. Does capacity do anything? IIRC, the default billing_mode for a table is pay-per-request, which doesn't use these values. From https://docs.aws.amazon.com/wellarchitected/latest/serverless-applications-lens/capacity.html With on-demand capacity mode, DynamoDB charges you for the data reads and writes your application performs on your tables. You do not need to specify how much read and write throughput you expect your application to perform because DynamoDB instantly accommodates your workloads as they ramp up or down.